feat(DestinationRules): Adding aggression and min_weight_percent to DestinationRules API (#3216)

* feat(): Adding aggression and min_weight_percent to DestinationRules API

Signed-off-by: Frédéric Gaudet <[email protected]>

* feat(): Wrapping slowStart parameters

Signed-off-by: Frédéric Gaudet <[email protected]>

* feat(): Adding aggression and min_weight_percent to DestinationRules API

Signed-off-by: Frédéric Gaudet <[email protected]>

* Update networking/v1alpha3/destination_rule.proto

Co-authored-by: John Howard <[email protected]>

* feat(): Regenerating protos

Signed-off-by: Frédéric Gaudet <[email protected]>

* feat(): Update documentation

Signed-off-by: Frédéric Gaudet <[email protected]>

* feat(): Adding validation in LoadBalancerSettings

Signed-off-by: Frédéric Gaudet <[email protected]>

* feat(): Adding tests and comments

Signed-off-by: Frédéric Gaudet <[email protected]>

* feat(): Fixing tests

Signed-off-by: Frédéric Gaudet <[email protected]>

* feat(): Make Duration field required

Signed-off-by: Frédéric Gaudet <[email protected]>

* feat(): Gen files

Signed-off-by: Frédéric Gaudet <[email protected]>

---------

Signed-off-by: Frédéric Gaudet <[email protected]>
Co-authored-by: John Howard <[email protected]>

Author: frgaudet

kubernetes/customresourcedefinitions.gen.yaml

@@ -377,6 +377,7 @@ message Subset {
 // ```
 //
 message LoadBalancerSettings {
+  // +kubebuilder:validation:XValidation:message="only one of warmupDurationSecs or warmup can be set",rule="(has(self.warmupDurationSecs)?1:0)+(has(self.warmup)?1:0)<=1"
   // Standard load balancing algorithms that require no tuning.
   enum SimpleLB {
     // No load balancing algorithm has been specified by the user. Istio
@@ -506,17 +507,36 @@ message LoadBalancerSettings {
   // between this object and the object one in MeshConfig
   LocalityLoadBalancerSetting locality_lb_setting = 3;
 
-  // Represents the warmup duration of Service. If set, the newly created endpoint of service
+  // Deprecated: use `warmup` instead.
+  google.protobuf.Duration warmup_duration_secs = 4;
+
+  // Represents the warmup configuration of Service. If set, the newly created endpoint of service
   // remains in warmup mode starting from its creation time for the duration of this window and
   // Istio progressively increases amount of traffic for that endpoint instead of sending proportional amount of traffic.
   // This should be enabled for services that require warm up time to serve full production load with reasonable latency.
   // Please note that this is most effective when few new endpoints come up like scale event in Kubernetes. When all the
   // endpoints are relatively new like new deployment, this is not very effective as all endpoints end up getting same
   // amount of requests.
   // Currently this is only supported for ROUND_ROBIN and LEAST_REQUEST load balancers.
-  google.protobuf.Duration warmup_duration_secs = 4;
+  WarmupConfiguration warmup = 5;
 }
 
+message WarmupConfiguration {
+  // Duration of warmup mode
+  google.protobuf.Duration duration = 1 [(google.api.field_behavior) = REQUIRED];
+
+  // Configures the minimum percentage of origin weight
+  // If unspecified, defaults to 10
+  // +kubebuilder:validation:Maximum=100
+  // +kubebuilder:validation:Minimum=0
+  google.protobuf.DoubleValue minimum_percent = 2;
+
+  // This parameter controls the speed of traffic increase over the warmup duration. Defaults to 1.0, so that endpoints would
+  // get linearly increasing amount of traffic. When increasing the value for this parameter,
+  // the speed of traffic ramp-up increases non-linearly.
+  // +kubebuilder:validation:Minimum=1
+  google.protobuf.DoubleValue aggression = 3;
+}
 // Connection pool settings for an upstream host. The settings apply to
 // each individual host in the upstream service.  See Envoy's [circuit
 // breaker](https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/circuit_breaking)

networking/v1/destination_rule_alias.gen.go

@@ -0,0 +1,13 @@
+apiVersion: release-notes/v2
+
+kind: feature
+area: traffic-management
+issue:
+- 3215
+
+releaseNotes:
+- |
+    **Added** aggression and minimum_percent parameters
+
+docs:
+  - https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/load_balancing/slow_start

networking/v1alpha3/destination_rule.pb.go

@@ -0,0 +1,37 @@
+_err: 'spec.trafficPolicy.loadBalancer.warmup.minimumPercent: Invalid value'
+apiVersion: networking.istio.io/v1
+kind: DestinationRule
+metadata:
+  name: bookinfo-ratings
+spec:
+  host: ratings.prod.svc.cluster.local
+  trafficPolicy:
+    loadBalancer:
+      warmup:
+        duration: 300s
+        minimumPercent: 150.0
+---
+_err: 'spec.trafficPolicy.loadBalancer.warmup.duration: Required value'
+apiVersion: networking.istio.io/v1
+kind: DestinationRule
+metadata:
+  name: bookinfo-ratings
+spec:
+  host: ratings.prod.svc.cluster.local
+  trafficPolicy:
+    loadBalancer:
+      warmup:
+        minimumPercent: 5.0
+---
+_err: 'spec.trafficPolicy.loadBalancer.warmup.aggression: Invalid value'
+apiVersion: networking.istio.io/v1
+kind: DestinationRule
+metadata:
+  name: bookinfo-ratings
+spec:
+  host: ratings.prod.svc.cluster.local
+  trafficPolicy:
+    loadBalancer:
+      warmup:
+        duration: 300s
+        aggression: 0.3