Skip to content

Commit 4881de7

Browse files
authored
Align REQUIRED declaration with reality (#2946)
The `REQUIRED` proto label currently does nothing. As a result, some of them are misaligned with reality -- fields marked REQUIRED are actually not required, and often even have valid behaviors and are used in the real world. Unfortunately, many of these are fields that *should* be required but are not. To maintain backwards compatibility, these cannot be made required at this point, sadly. In a future PR, I intend to make `REQUIRED` *actually make it required*, so this PR is a pre-requisite to doing that.
1 parent 1c39971 commit 4881de7

36 files changed

+1444
-1173
lines changed

networking/v1alpha3/destination_rule.pb.go

Lines changed: 64 additions & 64 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/destination_rule.pb.html

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/destination_rule.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1075,7 +1075,7 @@ message ClientTLSSettings {
10751075

10761076
// Indicates whether connections to this port should be secured
10771077
// using TLS. The value of this field determines how TLS is enforced.
1078-
TLSmode mode = 1 [(google.api.field_behavior) = REQUIRED];
1078+
TLSmode mode = 1;
10791079

10801080
// REQUIRED if mode is `MUTUAL`. The path to the file holding the
10811081
// client-side TLS certificate to use.

0 commit comments

Comments
 (0)