Skip to content

Commit 54d9596

Browse files
authored
Clarify ForwardClientCertDetails comments (#3315)
* Clarify ForwardClientCertDetails comments * update gen files * fix typo * remove mention of gateway proxy * fix default value for gw
1 parent 6723233 commit 54d9596

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

mesh/v1alpha1/istio.mesh.v1alpha1.pb.html

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

mesh/v1alpha1/proxy.pb.go

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

mesh/v1alpha1/proxy.proto

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -273,26 +273,26 @@ message Topology {
273273
}
274274

275275
// ForwardClientCertDetails controls how the x-forwarded-client-cert (XFCC)
276-
// header is handled by the gateway proxy.
276+
// header is handled by a proxy.
277277
// See [Envoy XFCC](https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/network/http_connection_manager/v3/http_connection_manager.proto.html#enum-extensions-filters-network-http-connection-manager-v3-httpconnectionmanager-forwardclientcertdetails)
278278
// header handling for more details.
279279
enum ForwardClientCertDetails {
280280
// Field is not set
281281
UNDEFINED = 0;
282282

283-
// Do not send the XFCC header to the next hop. This is the default value.
283+
// Do not send the XFCC header to the next hop.
284284
SANITIZE = 1;
285285

286286
// When the client connection is mTLS (Mutual TLS), forward the XFCC header
287287
// in the request.
288288
FORWARD_ONLY = 2;
289289

290290
// When the client connection is mTLS, append the client certificate
291-
// information to the request’s XFCC header and forward it.
291+
// information to the request’s XFCC header and forward it. This is the default value for sidecar proxies.
292292
APPEND_FORWARD = 3;
293293

294294
// When the client connection is mTLS, reset the XFCC header with the client
295-
// certificate information and send it to the next hop.
295+
// certificate information and send it to the next hop. This is the default value for gateway proxies.
296296
SANITIZE_SET = 4;
297297

298298
// Always forward the XFCC header in the request, regardless of whether the

0 commit comments

Comments
 (0)