Skip to content

Commit 6bbcb3e

Browse files
authored
Update api comment about query parameter. (#2712)
* Update api comment about query parameter * Make gen
1 parent 5d44158 commit 6bbcb3e

File tree

5 files changed

+16
-9
lines changed

5 files changed

+16
-9
lines changed

networking/v1alpha3/virtual_service.pb.go

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/virtual_service.pb.html

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/virtual_service.proto

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1100,11 +1100,12 @@ message HTTPMatchRequest {
11001100
// - For a query parameter like "?key", the map key would be "key" and the
11011101
// string match could be defined as `exact: ""`.
11021102
//
1103+
// - For a query parameter like "?key=abc" or "?key=abx", the map key would be "key" and the
1104+
// string match could be defined as `prefix: "ab"`.
1105+
//
11031106
// - For a query parameter like "?key=123", the map key would be "key" and the
11041107
// string match could be defined as `regex: "\d+$"`. Note that this
11051108
// configuration will only match values like "123" but not "a123" or "123a".
1106-
//
1107-
// **Note:** `prefix` matching is currently not supported.
11081109
map<string, StringMatch> query_params = 9;
11091110

11101111
// Flag to specify whether the URI matching should be case-insensitive.

networking/v1beta1/virtual_service.pb.go

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1beta1/virtual_service.proto

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1100,11 +1100,12 @@ message HTTPMatchRequest {
11001100
// - For a query parameter like "?key", the map key would be "key" and the
11011101
// string match could be defined as `exact: ""`.
11021102
//
1103+
// - For a query parameter like "?key=abc" or "?key=abx", the map key would be "key" and the
1104+
// string match could be defined as `prefix: "ab"`.
1105+
//
11031106
// - For a query parameter like "?key=123", the map key would be "key" and the
11041107
// string match could be defined as `regex: "\d+$"`. Note that this
11051108
// configuration will only match values like "123" but not "a123" or "123a".
1106-
//
1107-
// **Note:** `prefix` matching is currently not supported.
11081109
map<string, StringMatch> query_params = 9;
11091110

11101111
// Flag to specify whether the URI matching should be case-insensitive.

0 commit comments

Comments
 (0)