Skip to content

Conversation

shamsher31
Copy link
Member

The link was pointed to the old PR.

@shamsher31 shamsher31 added this to the 1.8 milestone Nov 23, 2020
@shamsher31 shamsher31 requested a review from a team as a code owner November 23, 2020 06:19
@shamsher31 shamsher31 self-assigned this Nov 23, 2020
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 23, 2020
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 23, 2020
@shamsher31
Copy link
Member Author

/retest

@@ -154,7 +154,7 @@ configure cross-network gateways without using [mesh networks](/docs/reference/c
([Issue #25933](https://github.com/istio/istio/issues/25933))

- **Added** support for Kubernetes versions 1.16 to 1.19 to Istio 1.8.
([Issue #25793](https://github.com/istio/istio/issues/25793))
([Pull Request #28814](https://github.com/istio/istio/pull/28814))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems gratuitous. Let's not make changes that require cherrypick unless they are bugs or broken links.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also thought we usually didn't point to PRs, although I've done it in the past.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the URL to point to issues that automatically redirect to PR if the issue does not exist.

I think this change is required because istio/istio#25793 displays the old supported version.

@shamsher31 shamsher31 requested review from frankbu and ericvn November 24, 2020 04:59
@shamsher31
Copy link
Member Author

/retest

@frankbu frankbu merged commit f3c54bb into istio:master Nov 24, 2020
@istio-testing
Copy link
Contributor

In response to a cherrypick label: new pull request created: #8567

@shamsher31 shamsher31 deleted the change-notes branch November 24, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants