From 91ff82dcb94b85c97be5f866c0b6671eb4400d03 Mon Sep 17 00:00:00 2001 From: istio-testing Date: Wed, 3 Dec 2025 03:00:59 +0000 Subject: [PATCH 01/14] Automator: update envoy@ in istio/proxy@master --- WORKSPACE | 6 +++--- envoy.bazelrc | 18 +++++++----------- 2 files changed, 10 insertions(+), 14 deletions(-) diff --git a/WORKSPACE b/WORKSPACE index 5668d248e9..064ba47048 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -22,10 +22,10 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") # 1. Determine SHA256 `wget https://github.com/envoyproxy/envoy/archive/$COMMIT.tar.gz && sha256sum $COMMIT.tar.gz` # 2. Update .bazelversion, envoy.bazelrc and .bazelrc if needed. # -# Commit date: 2025-12-02 -ENVOY_SHA = "44b00e0264cfcdbbc593998a407b3f957ec28c77" +# Commit date: 2025-12-03 +ENVOY_SHA = "1caf0d7396786bac7f4fcf7b9d291ed761191b68" -ENVOY_SHA256 = "1c8bc33cf9b758604042212d69d8bc37f41991facc43ed139d070b6b94aeddb0" +ENVOY_SHA256 = "10df99872f4f4c24c456970fdbedae1a25ecf2de4d4db57a34cd271f46fc7ac0" ENVOY_ORG = "envoyproxy" diff --git a/envoy.bazelrc b/envoy.bazelrc index bced9359e2..65d2fc272e 100644 --- a/envoy.bazelrc +++ b/envoy.bazelrc @@ -45,12 +45,6 @@ build --incompatible_merge_fixed_and_default_shell_env # A workaround for slow ICU download. build --http_timeout_scaling=6.0 -# Pass CC, CXX and LLVM_CONFIG variables from the environment. -# We assume they have stable values, so this won't cause action cache misses. -build --action_env=CC --host_action_env=CC -build --action_env=CXX --host_action_env=CXX -build --action_env=LLVM_CONFIG --host_action_env=LLVM_CONFIG - # Allow stamped caches to bust when local filesystem changes. # Requires setting `BAZEL_VOLATILE_DIRTY` in the env. build --action_env=BAZEL_VOLATILE_DIRTY --host_action_env=BAZEL_VOLATILE_DIRTY @@ -99,13 +93,14 @@ build:linux --cxxopt=-fsized-deallocation --host_cxxopt=-fsized-deallocation build:linux --conlyopt=-fexceptions build:linux --fission=dbg,opt build:linux --features=per_object_debug_info -build:linux --action_env=BAZEL_LINKOPTS=-lm:-fuse-ld=gold # macOS build:macos --action_env=PATH=/opt/homebrew/bin:/opt/local/bin:/usr/local/bin:/usr/bin:/bin build:macos --host_action_env=PATH=/opt/homebrew/bin:/opt/local/bin:/usr/local/bin:/usr/bin:/bin build:macos --define tcmalloc=disabled build:macos --cxxopt=-Wno-nullability-completeness +build:macos --@toolchains_llvm//toolchain/config:compiler-rt=false +build:macos --@toolchains_llvm//toolchain/config:libunwind=false ############################################################################# @@ -114,15 +109,14 @@ build:macos --cxxopt=-Wno-nullability-completeness # Common flags for Clang (shared between all clang variants) common:clang-common --linkopt=-fuse-ld=lld -common:clang-common --action_env=BAZEL_COMPILER=clang -common:clang-common --action_env=LDFLAGS="-fuse-ld=lld" -common:clang-common --action_env=CC=clang --host_action_env=CC=clang -common:clang-common --action_env=CXX=clang++ --host_action_env=CXX=clang++ +common:clang-common --@toolchains_llvm//toolchain/config:compiler-rt=false +common:clang-common --@toolchains_llvm//toolchain/config:libunwind=false # Clang with libc++ (default) common:clang --config=clang-common common:clang --config=libc++ common:clang --host_platform=@clang_platform +common:clang --repo_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 # Clang installed to non-standard location (ie not /opt/llvm/) common:clang-local --config=clang-common @@ -147,6 +141,8 @@ build:gcc --cxxopt=-Wno-dangling-reference build:gcc --cxxopt=-Wno-nonnull-compare build:gcc --linkopt=-fuse-ld=gold --host_linkopt=-fuse-ld=gold build:gcc --host_platform=@envoy//bazel/rbe/toolchains:rbe_linux_gcc_platform +build:gcc --linkopt=-fuse-ld=gold --host_linkopt=-fuse-ld=gold +build:gcc --action_env=BAZEL_LINKOPTS=-lm:-fuse-ld=gold # libc++ - default for clang common:libc++ --action_env=CXXFLAGS=-stdlib=libc++ From 8605cab18c5a1634f7add916f2d93e1d4d2b223e Mon Sep 17 00:00:00 2001 From: zirain Date: Wed, 3 Dec 2025 15:06:05 +0800 Subject: [PATCH 02/14] fix envoy build --- .bazelrc | 3 ++- WORKSPACE | 4 ---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/.bazelrc b/.bazelrc index 2c12247f25..4d23f64d40 100644 --- a/.bazelrc +++ b/.bazelrc @@ -14,7 +14,8 @@ build:remote --remote_timeout=7200 # ======================================== # Enable libc++ and C++20 by default. -build:linux --config=clang-local +build --repo_env=BAZEL_LLVM_PATH=/usr/lib/llvm +build:linux --config=clang # put /usr/local/bin before /usr/bin to avoid picking up wrong python3.6 when building envoy.tls.key_providers.cryptomb build:linux --action_env=PATH=/usr/lib/llvm/bin:/usr/local/bin:/bin:/usr/bin diff --git a/WORKSPACE b/WORKSPACE index 064ba47048..054b78f262 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -70,10 +70,6 @@ load("@envoy//bazel:python_dependencies.bzl", "envoy_python_dependencies") envoy_python_dependencies() -load("@base_pip3//:requirements.bzl", "install_deps") - -install_deps() - load("@envoy//bazel:dependency_imports.bzl", "envoy_dependency_imports") envoy_dependency_imports() From af244afcec5105b3fbf8f2ad307e5bf1324da85f Mon Sep 17 00:00:00 2001 From: zirain Date: Wed, 3 Dec 2025 18:50:11 +0800 Subject: [PATCH 03/14] register llvm tool --- .bazelrc | 6 +++--- WORKSPACE | 5 +++++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/.bazelrc b/.bazelrc index 4d23f64d40..ccd1bd8d78 100644 --- a/.bazelrc +++ b/.bazelrc @@ -14,7 +14,7 @@ build:remote --remote_timeout=7200 # ======================================== # Enable libc++ and C++20 by default. -build --repo_env=BAZEL_LLVM_PATH=/usr/lib/llvm +# build --repo_env=BAZEL_LLVM_PATH=/usr/lib/llvm build:linux --config=clang # put /usr/local/bin before /usr/bin to avoid picking up wrong python3.6 when building envoy.tls.key_providers.cryptomb @@ -51,8 +51,8 @@ build:debug -c dbg build --cxxopt -Wformat build --cxxopt -Wformat-security -build:clang --host_action_env=CC= -build:clang --host_action_env=CXX= +# build:clang --host_action_env=CC= +# build:clang --host_action_env=CXX= # CI sanitizer configuration # diff --git a/WORKSPACE b/WORKSPACE index 054b78f262..f574e1465a 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -81,3 +81,8 @@ envoy_repo() load("@envoy//bazel:toolchains.bzl", "envoy_toolchains") envoy_toolchains() + +load("@llvm_toolchain//:toolchains.bzl", "llvm_register_toolchains") + +llvm_register_toolchains() + From a0820abad4164da01029bcea2eaf69164953e8d4 Mon Sep 17 00:00:00 2001 From: zirain Date: Fri, 5 Dec 2025 13:48:31 +0800 Subject: [PATCH 04/14] fix --- .bazelrc | 2 +- WORKSPACE | 30 ++++++++++++++++++++++++------ envoy.bazelrc | 3 +++ 3 files changed, 28 insertions(+), 7 deletions(-) diff --git a/.bazelrc b/.bazelrc index ccd1bd8d78..db7a98f986 100644 --- a/.bazelrc +++ b/.bazelrc @@ -14,7 +14,7 @@ build:remote --remote_timeout=7200 # ======================================== # Enable libc++ and C++20 by default. -# build --repo_env=BAZEL_LLVM_PATH=/usr/lib/llvm +build --repo_env=BAZEL_LLVM_PATH=/usr/lib/llvm build:linux --config=clang # put /usr/local/bin before /usr/bin to avoid picking up wrong python3.6 when building envoy.tls.key_providers.cryptomb diff --git a/WORKSPACE b/WORKSPACE index f574e1465a..f78cd83e68 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -22,10 +22,10 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") # 1. Determine SHA256 `wget https://github.com/envoyproxy/envoy/archive/$COMMIT.tar.gz && sha256sum $COMMIT.tar.gz` # 2. Update .bazelversion, envoy.bazelrc and .bazelrc if needed. # -# Commit date: 2025-12-03 -ENVOY_SHA = "1caf0d7396786bac7f4fcf7b9d291ed761191b68" +# Commit date: 2025-12-05 +ENVOY_SHA = "df7ddf53f997efd9e080f5940bd996ee9827405b" -ENVOY_SHA256 = "10df99872f4f4c24c456970fdbedae1a25ecf2de4d4db57a34cd271f46fc7ac0" +ENVOY_SHA256 = "481954044392c767e58b5971f3f0e53baa1707b62f20fca63794fefd279b9c90" ENVOY_ORG = "envoyproxy" @@ -78,11 +78,29 @@ load("@envoy//bazel:repo.bzl", "envoy_repo") envoy_repo() -load("@envoy//bazel:toolchains.bzl", "envoy_toolchains") -envoy_toolchains() +# this's workaround for use local LLVM toolchain +load("@envoy_repo//:compiler.bzl", "LLVM_PATH") +load("@envoy_toolshed//repository:utils.bzl", "arch_alias") +load("@toolchains_llvm//toolchain:rules.bzl", "llvm_toolchain") + +register_toolchains("@envoy//bazel/rbe/toolchains/configs/linux/gcc/config:cc-toolchain") + +arch_alias( + name = "clang_platform", + aliases = { + "amd64": "@envoy//bazel/platforms/rbe:linux_x64", + "aarch64": "@envoy//bazel/platforms/rbe:linux_arm64", + }, +) + +llvm_toolchain( + name = "llvm_toolchain", + cxx_standard = {"": "c++20"}, + llvm_version = "18.1.8", + toolchain_roots = {"": LLVM_PATH} if LLVM_PATH else {}, +) load("@llvm_toolchain//:toolchains.bzl", "llvm_register_toolchains") llvm_register_toolchains() - diff --git a/envoy.bazelrc b/envoy.bazelrc index 65d2fc272e..4fa35b1474 100644 --- a/envoy.bazelrc +++ b/envoy.bazelrc @@ -391,6 +391,9 @@ build:remote --strategy=Javac=remote,sandboxed,local build:remote --strategy=Closure=remote,sandboxed,local build:remote --strategy=Genrule=remote,sandboxed,local build:remote --action_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 +# This flag may be more generally useful - it sets foreign_cc builds -jauto. +# It is only set here because if it were the default it risks OOMing on local builds. +build:remote --@envoy//bazel/foreign_cc:parallel_builds ## RBE (Engflow Envoy) From d2133c26b53e4832bca45a87b2fb6d35c6c9b92f Mon Sep 17 00:00:00 2001 From: zirain Date: Fri, 5 Dec 2025 17:38:24 +0800 Subject: [PATCH 05/14] fix lint --- .bazelrc | 2 +- WORKSPACE | 51 +++++++++++++++++++++++++++------------------------ 2 files changed, 28 insertions(+), 25 deletions(-) diff --git a/.bazelrc b/.bazelrc index db7a98f986..5f99f4d2f9 100644 --- a/.bazelrc +++ b/.bazelrc @@ -59,7 +59,7 @@ build --cxxopt -Wformat-security build:clang-asan-ci --config=asan build:clang-asan-ci --linkopt='-L/usr/lib/llvm/lib/x86_64-unknown-linux-gnu' build:clang-asan-ci --linkopt='-Wl,-rpath,/usr/lib/llvm/lib/x86_64-unknown-linux-gnu' -build:clang-asan-ci --linkopt='-L/usr/lib/llvm/lib/clang/14.0.0/lib/x86_64-unknown-linux-gnu' +build:clang-asan-ci --linkopt='-L/usr/lib/llvm/lib/clang/18/lib/x86_64-unknown-linux-gnu' build:clang-tsan-ci --config=tsan build:clang-tsan-ci --linkopt=-L/opt/libcxx_tsan/lib diff --git a/WORKSPACE b/WORKSPACE index f78cd83e68..f928d977bd 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -78,29 +78,32 @@ load("@envoy//bazel:repo.bzl", "envoy_repo") envoy_repo() +load("@envoy//bazel:toolchains.bzl", "envoy_toolchains") -# this's workaround for use local LLVM toolchain -load("@envoy_repo//:compiler.bzl", "LLVM_PATH") -load("@envoy_toolshed//repository:utils.bzl", "arch_alias") -load("@toolchains_llvm//toolchain:rules.bzl", "llvm_toolchain") - -register_toolchains("@envoy//bazel/rbe/toolchains/configs/linux/gcc/config:cc-toolchain") - -arch_alias( - name = "clang_platform", - aliases = { - "amd64": "@envoy//bazel/platforms/rbe:linux_x64", - "aarch64": "@envoy//bazel/platforms/rbe:linux_arm64", - }, -) - -llvm_toolchain( - name = "llvm_toolchain", - cxx_standard = {"": "c++20"}, - llvm_version = "18.1.8", - toolchain_roots = {"": LLVM_PATH} if LLVM_PATH else {}, -) - -load("@llvm_toolchain//:toolchains.bzl", "llvm_register_toolchains") +envoy_toolchains() -llvm_register_toolchains() +# this's workaround for use local LLVM toolchain +# load("@envoy_repo//:compiler.bzl", "LLVM_PATH") +# load("@envoy_toolshed//repository:utils.bzl", "arch_alias") +# load("@toolchains_llvm//toolchain:rules.bzl", "llvm_toolchain") + +# register_toolchains("@envoy//bazel/rbe/toolchains/configs/linux/gcc/config:cc-toolchain") + +# arch_alias( +# name = "clang_platform", +# aliases = { +# "amd64": "@envoy//bazel/platforms/rbe:linux_x64", +# "aarch64": "@envoy//bazel/platforms/rbe:linux_arm64", +# }, +# ) + +# llvm_toolchain( +# name = "llvm_toolchain", +# cxx_standard = {"": "c++20"}, +# llvm_version = "18.1.8", +# toolchain_roots = {"": LLVM_PATH} if LLVM_PATH else {}, +# ) + +# load("@llvm_toolchain//:toolchains.bzl", "llvm_register_toolchains") + +# llvm_register_toolchains() From 8c6d88230b74e827a75fb852f1d2cdc9b1c4c03e Mon Sep 17 00:00:00 2001 From: Ryan Northey Date: Fri, 5 Dec 2025 11:42:35 +0000 Subject: [PATCH 06/14] Makefile.core.mk --- Makefile.core.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.core.mk b/Makefile.core.mk index a8d71344ac..f0a436475b 100644 --- a/Makefile.core.mk +++ b/Makefile.core.mk @@ -53,7 +53,7 @@ TEST_ENVOY_TARGET ?= //:envoy TEST_ENVOY_DEBUG ?= trace build: - bazel $(BAZEL_STARTUP_ARGS) build $(BAZEL_BUILD_ARGS) $(BAZEL_CONFIG_CURRENT) -- $(BAZEL_TARGETS) + bazel $(BAZEL_STARTUP_ARGS) build --config=clang $(BAZEL_BUILD_ARGS) $(BAZEL_CONFIG_CURRENT) -- $(BAZEL_TARGETS) build_envoy: BAZEL_CONFIG_CURRENT = $(BAZEL_CONFIG_REL) build_envoy: BAZEL_TARGETS = //:envoy From 5bd78c92179182788f390321a0c5865465bc5587 Mon Sep 17 00:00:00 2001 From: Ryan Northey Date: Fri, 5 Dec 2025 12:04:20 +0000 Subject: [PATCH 07/14] WORKSPACE --- WORKSPACE | 37 +++++++++++++++++++------------------ 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/WORKSPACE b/WORKSPACE index f928d977bd..586ebe64d3 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -83,27 +83,28 @@ load("@envoy//bazel:toolchains.bzl", "envoy_toolchains") envoy_toolchains() # this's workaround for use local LLVM toolchain -# load("@envoy_repo//:compiler.bzl", "LLVM_PATH") -# load("@envoy_toolshed//repository:utils.bzl", "arch_alias") -# load("@toolchains_llvm//toolchain:rules.bzl", "llvm_toolchain") +load("@envoy_repo//:compiler.bzl", "LLVM_PATH") +load("@envoy_toolshed//repository:utils.bzl", "arch_alias") +load("@toolchains_llvm//toolchain:rules.bzl", "llvm_toolchain") # register_toolchains("@envoy//bazel/rbe/toolchains/configs/linux/gcc/config:cc-toolchain") -# arch_alias( -# name = "clang_platform", -# aliases = { -# "amd64": "@envoy//bazel/platforms/rbe:linux_x64", -# "aarch64": "@envoy//bazel/platforms/rbe:linux_arm64", -# }, -# ) +arch_alias( + name = "clang_platform", + aliases = { + "amd64": "@envoy//bazel/platforms/rbe:linux_x64", + "aarch64": "@envoy//bazel/platforms/rbe:linux_arm64", + }, +) + -# llvm_toolchain( -# name = "llvm_toolchain", -# cxx_standard = {"": "c++20"}, -# llvm_version = "18.1.8", -# toolchain_roots = {"": LLVM_PATH} if LLVM_PATH else {}, -# ) +llvm_toolchain( + name = "llvm_toolchain", + cxx_standard = {"": "c++20"}, + llvm_version = "18.1.8", + toolchain_roots = {"": LLVM_PATH} if LLVM_PATH else {}, +) -# load("@llvm_toolchain//:toolchains.bzl", "llvm_register_toolchains") +load("@llvm_toolchain//:toolchains.bzl", "llvm_register_toolchains") -# llvm_register_toolchains() +llvm_register_toolchains() From ab858fe8342a561e3bf984732a9b4d89ed9779e2 Mon Sep 17 00:00:00 2001 From: Ryan Northey Date: Fri, 5 Dec 2025 12:10:41 +0000 Subject: [PATCH 08/14] WORKSPACE --- WORKSPACE | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/WORKSPACE b/WORKSPACE index 586ebe64d3..b4f741a56b 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -78,9 +78,9 @@ load("@envoy//bazel:repo.bzl", "envoy_repo") envoy_repo() -load("@envoy//bazel:toolchains.bzl", "envoy_toolchains") +# load("@envoy//bazel:toolchains.bzl", "envoy_toolchains") -envoy_toolchains() +# envoy_toolchains() # this's workaround for use local LLVM toolchain load("@envoy_repo//:compiler.bzl", "LLVM_PATH") From 8e5ba197556facb40f1a2ac1818c67b8e8ced561 Mon Sep 17 00:00:00 2001 From: Ryan Northey Date: Fri, 5 Dec 2025 12:35:20 +0000 Subject: [PATCH 09/14] WORKSPACE --- WORKSPACE | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/WORKSPACE b/WORKSPACE index b4f741a56b..a92d158f1f 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -97,12 +97,11 @@ arch_alias( }, ) - llvm_toolchain( name = "llvm_toolchain", cxx_standard = {"": "c++20"}, llvm_version = "18.1.8", - toolchain_roots = {"": LLVM_PATH} if LLVM_PATH else {}, + toolchain_roots = "/usr/lib/llvm", ) load("@llvm_toolchain//:toolchains.bzl", "llvm_register_toolchains") From 84a650450a4e028f2780e768f63ac1c5d0740c9b Mon Sep 17 00:00:00 2001 From: Ryan Northey Date: Fri, 5 Dec 2025 12:40:30 +0000 Subject: [PATCH 10/14] WORKSPACE --- WORKSPACE | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WORKSPACE b/WORKSPACE index a92d158f1f..6473ef0c1e 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -101,7 +101,7 @@ llvm_toolchain( name = "llvm_toolchain", cxx_standard = {"": "c++20"}, llvm_version = "18.1.8", - toolchain_roots = "/usr/lib/llvm", + toolchain_root = "/usr/lib/llvm", ) load("@llvm_toolchain//:toolchains.bzl", "llvm_register_toolchains") From f7eb039efda485bec0972a747162601e14b614dd Mon Sep 17 00:00:00 2001 From: Ryan Northey Date: Fri, 5 Dec 2025 12:43:25 +0000 Subject: [PATCH 11/14] WORKSPACE --- WORKSPACE | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WORKSPACE b/WORKSPACE index 6473ef0c1e..1dd62647ec 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -101,7 +101,7 @@ llvm_toolchain( name = "llvm_toolchain", cxx_standard = {"": "c++20"}, llvm_version = "18.1.8", - toolchain_root = "/usr/lib/llvm", + toolchain_roots = {"": "/usr/lib/llvm"} ) load("@llvm_toolchain//:toolchains.bzl", "llvm_register_toolchains") From 91643f101b1231bc02bf1c0619ab9eb248a20dae Mon Sep 17 00:00:00 2001 From: Ryan Northey Date: Fri, 5 Dec 2025 12:47:11 +0000 Subject: [PATCH 12/14] prow/ --- prow/proxy-presubmit-asan.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/prow/proxy-presubmit-asan.sh b/prow/proxy-presubmit-asan.sh index adc19ecae7..ea352448b6 100755 --- a/prow/proxy-presubmit-asan.sh +++ b/prow/proxy-presubmit-asan.sh @@ -24,4 +24,5 @@ WD=$(cd "$WD" || exit 1 ; pwd) source "${WD}/proxy-common.inc" echo 'Bazel Tests' +cat WORKSPACE make test_asan From 07281d00f04e2f0083a5c90fbe2756070f4bc153 Mon Sep 17 00:00:00 2001 From: Ryan Northey Date: Fri, 5 Dec 2025 12:50:27 +0000 Subject: [PATCH 13/14] .bazelrc --- .bazelrc | 1 + 1 file changed, 1 insertion(+) diff --git a/.bazelrc b/.bazelrc index 5f99f4d2f9..2414b9cdf5 100644 --- a/.bazelrc +++ b/.bazelrc @@ -56,6 +56,7 @@ build --cxxopt -Wformat-security # CI sanitizer configuration # +build:clang-asan-ci --config=clang build:clang-asan-ci --config=asan build:clang-asan-ci --linkopt='-L/usr/lib/llvm/lib/x86_64-unknown-linux-gnu' build:clang-asan-ci --linkopt='-Wl,-rpath,/usr/lib/llvm/lib/x86_64-unknown-linux-gnu' From 539ce13b37ab7222d7f229ea4cca57c54b58f404 Mon Sep 17 00:00:00 2001 From: Ryan Northey Date: Fri, 5 Dec 2025 13:12:25 +0000 Subject: [PATCH 14/14] more --- prow/proxy-presubmit-asan.sh | 1 - scripts/release-binary.sh | 3 +++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/prow/proxy-presubmit-asan.sh b/prow/proxy-presubmit-asan.sh index ea352448b6..adc19ecae7 100755 --- a/prow/proxy-presubmit-asan.sh +++ b/prow/proxy-presubmit-asan.sh @@ -24,5 +24,4 @@ WD=$(cd "$WD" || exit 1 ; pwd) source "${WD}/proxy-common.inc" echo 'Bazel Tests' -cat WORKSPACE make test_asan diff --git a/scripts/release-binary.sh b/scripts/release-binary.sh index b2419a6407..274b0cc569 100755 --- a/scripts/release-binary.sh +++ b/scripts/release-binary.sh @@ -124,6 +124,9 @@ do BAZEL_OUT="$(bazel info ${BAZEL_BUILD_ARGS} output_path)/${ARCH_NAME}-opt/bin" ;; "asan") + echo "ASAN RELEASE TEST" + cat WORKSPACE + # Asan is skipped on ARM64 if [[ "$(uname -m)" != "aarch64" ]]; then # NOTE: libc++ is dynamically linked in this build.