Skip to content

Commit 39b3273

Browse files
committed
Improve robustness of client solve time metric recording
1 parent ed2200e commit 39b3273

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

captchaservice-backend/src/main/java/de/muenchen/captchaservice/service/captcha/CaptchaService.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import de.muenchen.captchaservice.entity.InvalidatedPayload;
88
import de.muenchen.captchaservice.repository.InvalidatedPayloadRepository;
99
import de.muenchen.captchaservice.service.difficulty.DifficultyService;
10+
import de.muenchen.captchaservice.service.metrics.MetricsService;
1011
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
1112
import lombok.extern.slf4j.Slf4j;
1213
import org.altcha.altcha.Altcha;
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package de.muenchen.captchaservice.service.captcha;
1+
package de.muenchen.captchaservice.service.metrics;
22

33
import de.muenchen.captchaservice.data.SourceAddress;
44
import de.muenchen.captchaservice.repository.CaptchaRequestRepository;
@@ -57,8 +57,8 @@ public void recordVerifySuccess(String siteKey, SourceAddress sourceAddress) {
5757
.increment();
5858
}
5959

60-
public void recordClientSolveTime(String siteKey, SourceAddress sourceAddress, long solveTime) {
61-
if (solveTime <= 0) {
60+
public void recordClientSolveTime(String siteKey, SourceAddress sourceAddress, Long solveTime) {
61+
if (solveTime == null || solveTime < 0) {
6262
log.warn("Invalid solve time value: {} for site: {}", solveTime, sanitizeForLog(siteKey));
6363
return;
6464
}

0 commit comments

Comments
 (0)