Skip to content

Commit 13bdf24

Browse files
committed
🐛 sort checklists by last update
1 parent d5f72f1 commit 13bdf24

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

personalization-service/src/main/java/de/muenchen/dbs/personalization/checklist/ChecklistRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@
99
@Repository
1010
public interface ChecklistRepository extends JpaRepository<Checklist, UUID> {
1111

12-
List<Checklist> findChecklistByLhmExtId(String lhmExtId);
12+
List<Checklist> findChecklistByLhmExtIdOrderByLastUpdateDesc(String lhmExtId);
1313

1414
}

personalization-service/src/main/java/de/muenchen/dbs/personalization/checklist/ChecklistService.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,14 @@ public Checklist createChecklist(final Checklist checklist) {
2929
final String lhmExtId = getLhmExtIdFromAuthenticationOrThrow();
3030
log.debug("Create Checklist {} for {}", checklist, lhmExtId);
3131
checklist.setLhmExtId(lhmExtId);
32+
checklist.setLastUpdate(ZonedDateTime.now());
3233
return checklistRepository.save(checklist);
3334
}
3435

3536
public List<Checklist> getChecklists() {
3637
final String lhmExtId = getLhmExtIdFromAuthenticationOrThrow();
3738
log.debug("Get all checklists of {}", lhmExtId);
38-
return checklistRepository.findChecklistByLhmExtId(lhmExtId);
39+
return checklistRepository.findChecklistByLhmExtIdOrderByLastUpdateDesc(lhmExtId);
3940
}
4041

4142
public Checklist getChecklist(final UUID checklistId) {

personalization-service/src/test/java/de/muenchen/dbs/personalization/checklist/ChecklistServiceTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,14 +88,14 @@ void givenLhmExtId_thenReturnChecklists() {
8888
final Checklist checklist1 = createTestChecklist(id1, USER_LHM_EXT_ID, null);
8989
final Checklist checklist2 = createTestChecklist(id2, USER_LHM_EXT_ID, null);
9090

91-
when(checklistRepository.findChecklistByLhmExtId(USER_LHM_EXT_ID)).thenReturn(List.of(checklist1, checklist2));
91+
when(checklistRepository.findChecklistByLhmExtIdOrderByLastUpdateDesc(USER_LHM_EXT_ID)).thenReturn(List.of(checklist1, checklist2));
9292

9393
// When
9494
final List<Checklist> result = checklistService.getChecklists();
9595

9696
// Then
9797
Assertions.assertEquals(List.of(checklist1, checklist2), result);
98-
verify(checklistRepository, times(1)).findChecklistByLhmExtId(USER_LHM_EXT_ID);
98+
verify(checklistRepository, times(1)).findChecklistByLhmExtIdOrderByLastUpdateDesc(USER_LHM_EXT_ID);
9999
}
100100

101101
}

0 commit comments

Comments
 (0)