💚 make pmd happy

Author: FabianWilms

personalization-service/src/main/java/de/muenchen/dbs/personalization/checklist/ChecklistController.java

@@ -23,6 +23,9 @@
 @Tag(name = "Checklists", description = "Creating, reading and deleting Checklists.")
 public class ChecklistController {
 
+    public static final String PATH_VAR_CHECKLIST_ID = "checklistID";
+    public static final String PATH_VAR_SERVICE_ID = "serviceID";
+
     private final ChecklistService checklistService;
     private final ChecklistMapper checklistMapper;
 
@@ -34,10 +37,10 @@ public List<ChecklistReadDTO> getChecklists() {
         return checklists.stream().map(checklistMapper::toReadDTO).toList();
     }
 
-    @GetMapping(path = "/{checklistID}")
+    @GetMapping(path = "/{" + PATH_VAR_CHECKLIST_ID + "}")
     @Operation(summary = "Get specific checklist by checklist-id.", description = "Returns a checklist by checklistId")
     @ResponseStatus(HttpStatus.OK)
-    public ChecklistReadDTO getChecklist(@PathVariable("checklistID") final UUID checklistID) {
+    public ChecklistReadDTO getChecklist(@PathVariable(PATH_VAR_CHECKLIST_ID) final UUID checklistID) {
         return checklistMapper.toReadDTO(checklistService.getChecklist(checklistID));
     }
 
@@ -57,26 +60,26 @@ public ChecklistReadDTO updateChecklist(@Valid @RequestBody final ChecklistUpdat
         return checklistMapper.toReadDTO(checklistService.updateChecklist(checklistMapper.toUpdateChecklist(checklistUpdateDTO), checklistID));
     }
 
-    @DeleteMapping("/{checklistID}")
+    @DeleteMapping("/{" + PATH_VAR_CHECKLIST_ID + "}")
     @Operation(summary = "Delete a checklist", description = "Deletes a checklist by checklistId.")
     @ResponseStatus(HttpStatus.OK)
-    public void deleteChecklist(@PathVariable("checklistID") final UUID checklistID) {
+    public void deleteChecklist(@PathVariable(PATH_VAR_CHECKLIST_ID) final UUID checklistID) {
         checklistService.deleteChecklist(checklistID);
     }
 
-    @PostMapping("/{checklistID}/{serviceID}/check")
+    @PostMapping("/{" + PATH_VAR_CHECKLIST_ID + "}/{" + PATH_VAR_SERVICE_ID + "}/check")
     @Operation(summary = "Check a Checklist-Entry", description = "Checks a checklist-entry.")
     @ResponseStatus(HttpStatus.OK)
-    public ChecklistReadDTO checkChecklistEntry(@PathVariable("checklistID") final UUID checklistID,
-            @PathVariable("serviceID") final String serviceID) {
+    public ChecklistReadDTO checkChecklistEntry(@PathVariable(PATH_VAR_CHECKLIST_ID) final UUID checklistID,
+            @PathVariable(PATH_VAR_SERVICE_ID) final String serviceID) {
         return checklistMapper.toReadDTO(checklistService.changeChecklistEntry(checklistID, serviceID, ZonedDateTime.now()));
     }
 
-    @PostMapping("/{checklistID}/{serviceID}/uncheck")
+    @PostMapping("/{" + PATH_VAR_CHECKLIST_ID + "}/{" + PATH_VAR_SERVICE_ID + "}/uncheck")
     @Operation(summary = "Check a Checklist-Entry", description = "Checks a checklist-entry.")
     @ResponseStatus(HttpStatus.OK)
-    public ChecklistReadDTO uncheckChecklistEntry(@PathVariable("checklistID") final UUID checklistID,
-            @PathVariable("serviceID") final String serviceID) {
+    public ChecklistReadDTO uncheckChecklistEntry(@PathVariable(PATH_VAR_CHECKLIST_ID) final UUID checklistID,
+            @PathVariable(PATH_VAR_SERVICE_ID) final String serviceID) {
         return checklistMapper.toReadDTO(checklistService.changeChecklistEntry(checklistID, serviceID, null));
     }
 }

personalization-service/src/main/java/de/muenchen/dbs/personalization/checklist/ChecklistService.java

@@ -71,7 +71,7 @@ public void deleteChecklist(final UUID checklistId) {
         checklistRepository.deleteById(checklistId);
     }
 
-    public Checklist changeChecklistEntry(final UUID checklistId, final String serviceId, ZonedDateTime newCheckedValue) {
+    public Checklist changeChecklistEntry(final UUID checklistId, final String serviceId, final ZonedDateTime newCheckedValue) {
         final String lhmExtId = getLhmExtIdFromAuthenticationOrThrow();
         final String sanitizedServiceId = StringEscapeUtils.escapeHtml4(serviceId);
         log.debug("Update checklist with checklist-ID {} and service-ID {} for {}", checklistId, sanitizedServiceId, lhmExtId);