chore(dms): throw exception if DMS target key missing in metadata file (#315)

* chore(dms): handle dms target key missing in medata file

* test(dms): handle dms target key missing in medata file

Author: simonhir

dms-service/src/main/java/de/muenchen/oss/swim/dms/application/usecase/helper/TargetResolverHelper.java

@@ -173,6 +173,9 @@ public UseCaseType resolveTypeFromMetadataFile(final Metadata metadata) throws M
         // load value from metadata file
         final Map<String, String> indexFields = metadata.indexFields();
         final String metadataDmsTarget = indexFields.get(swimDmsProperties.getMetadataDmsTargetKey());
+        if (StringUtils.isBlank(metadataDmsTarget)) {
+            throw new MetadataException("DMS target key '%s' not found in metadata file or empty".formatted(swimDmsProperties.getMetadataDmsTargetKey()));
+        }
         // resolve type from value
         try {
             final UseCaseType resolvedType = UseCaseType.valueOf(metadataDmsTarget.toUpperCase(Locale.ROOT));

dms-service/src/test/java/de/muenchen/oss/swim/dms/application/usecase/helper/TargetResolverHelperTest.java

@@ -0,0 +1,54 @@
+package de.muenchen.oss.swim.dms.application.usecase.helper;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import de.muenchen.oss.swim.dms.TestConstants;
+import de.muenchen.oss.swim.dms.application.port.out.DmsOutPort;
+import de.muenchen.oss.swim.dms.configuration.SwimDmsProperties;
+import de.muenchen.oss.swim.dms.domain.helper.DmsMetadataHelper;
+import de.muenchen.oss.swim.dms.domain.model.UseCaseType;
+import de.muenchen.oss.swim.libs.handlercore.domain.exception.MetadataException;
+import de.muenchen.oss.swim.libs.handlercore.domain.helper.PatternHelper;
+import de.muenchen.oss.swim.libs.handlercore.domain.model.Metadata;
+import java.util.Map;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.junit.jupiter.MockitoExtension;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.context.properties.EnableConfigurationProperties;
+import org.springframework.boot.test.context.SpringBootTest;
+import org.springframework.test.context.ActiveProfiles;
+import org.springframework.test.context.bean.override.mockito.MockitoBean;
+
+@SpringBootTest(
+        classes = { SwimDmsProperties.class, TargetResolverHelper.class, ObjectMapper.class, DmsMetadataHelper.class, PatternHelper.class }
+)
+@EnableConfigurationProperties
+@ExtendWith(MockitoExtension.class)
+@ActiveProfiles(TestConstants.SPRING_TEST_PROFILE)
+class TargetResolverHelperTest {
+    @Autowired
+    private TargetResolverHelper targetResolverHelper;
+    @MockitoBean
+    private DmsOutPort dmsOutPort;
+
+    @Test
+    void testResolveTypeFromMetadataFile() throws MetadataException {
+        final Metadata metadata = new Metadata(null, Map.of("SWIM_DMS_Target", "inbox_incoming"));
+        assertEquals(UseCaseType.INBOX_INCOMING, targetResolverHelper.resolveTypeFromMetadataFile(metadata));
+    }
+
+    @Test
+    void testResolveTypeFromMetadataFile_KeyMissing() {
+        // empty map
+        final Metadata metadata = new Metadata(null, Map.of());
+        final MetadataException exception = assertThrows(MetadataException.class, () -> targetResolverHelper.resolveTypeFromMetadataFile(metadata));
+        assertEquals("DMS target key 'SWIM_DMS_Target' not found in metadata file or empty", exception.getMessage());
+        // empty value
+        final Metadata metadata2 = new Metadata(null, Map.of("SWIM_DMS_Target", ""));
+        final MetadataException exception2 = assertThrows(MetadataException.class, () -> targetResolverHelper.resolveTypeFromMetadataFile(metadata2));
+        assertEquals("DMS target key 'SWIM_DMS_Target' not found in metadata file or empty", exception2.getMessage());
+    }
+}