Skip to content

Commit 778a5ea

Browse files
Merge pull request #16 from it-shark-pro/check-lines-of-code
fixed linesOfCode extension
2 parents 1fbb1b4 + 466ea4c commit 778a5ea

32 files changed

+523
-2697
lines changed

.babelrc

Lines changed: 0 additions & 3 deletions
This file was deleted.

.eslintrc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
{
2-
"parserOptions": {
3-
"sourceType": "module"
4-
},
52
"env": {
63
"es6": true,
74
"node": true

extensions/assert-linesOfCode.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
1-
import assert from 'assert';
1+
const assert = require('assert');
22

33
function linesOfCode(fn, expected, recommended) {
44
const actualLinesOfCode = fn.toString().split('\n').filter(s => s.trim()).length - 2;
55
const isValid = actualLinesOfCode <= expected;
6-
if (actualLinesOfCode <= expected && actualLinesOfCode > recommended) {
7-
console.log(`Recommended lines of code for ${fn.name} is ${recommended}`);
8-
}
9-
const message = `
6+
7+
const messages = [`
108
"${fn.name}" should have maximum ${expected} line(s) of code but it ${actualLinesOfCode}.
11-
Recommended lines of code for ${fn.name} is ${recommended}
12-
`;
9+
`];
10+
if (recommended && !isValid && actualLinesOfCode > recommended) {
11+
messages.push(`Recommended lines of code for ${fn.name} is ${recommended}`);
12+
}
1313

14-
assert.ok(isValid, message);
14+
assert.ok(isValid, messages.join('\n'));
1515
}
1616

1717
assert.linesOfCode = linesOfCode;

0 commit comments

Comments
 (0)