Skip to content

Commit 9c13037

Browse files
committed
fixed linesOfCode extension
1 parent 8d06814 commit 9c13037

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

extensions/assert-linesOfCode.js

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,19 @@
11
import assert from 'assert';
22

3+
const exclude = ['', ');'];
4+
35
function linesOfCode(fn, expected, recommended) {
4-
const actualLinesOfCode = fn.toString().split('\n').filter(s => s.trim()).length - 2;
6+
const actualLinesOfCode = fn.toString().split('\n').filter(s => !exclude.includes(s.trim())).length - 2;
57
const isValid = actualLinesOfCode <= expected;
6-
if (actualLinesOfCode <= expected && actualLinesOfCode > recommended) {
7-
console.log(`Recommended lines of code for ${fn.name} is ${recommended}`);
8-
}
9-
const message = `
8+
9+
const messages = [`
1010
"${fn.name}" should have maximum ${expected} line(s) of code but it ${actualLinesOfCode}.
11-
Recommended lines of code for ${fn.name} is ${recommended}
12-
`;
11+
`];
12+
if (recommended && !isValid && actualLinesOfCode > recommended) {
13+
messages.push(`Recommended lines of code for ${fn.name} is ${recommended}`);
14+
}
1315

14-
assert.ok(isValid, message);
16+
assert.ok(isValid, messages.join('\n'));
1517
}
1618

1719
assert.linesOfCode = linesOfCode;

0 commit comments

Comments
 (0)