Merge pull request #420 from italia/fix/direct_post_psub

fix: handling of presentation sub in direct post

Author: peppelinux

pyeudiw/openid4vp/authorization_response.py

@@ -1,3 +1,4 @@
+import json
 from typing import TypeVar
 import cryptojwt.jwe.exception
 import satosa.context
@@ -98,7 +99,10 @@ def parse_and_validate(
             if (state := resp_data.get("state", None)):
                 d["state"] = state
             if (presentation_submission := resp_data["presentation_submission"]):
-                d["presentation_submission"] = presentation_submission
+                if isinstance(presentation_submission, dict):
+                    d["presentation_submission"] = presentation_submission
+                else:
+                    d["presentation_submission"] = json.loads(presentation_submission)
             return AuthorizeResponsePayload(**d)
         except Exception as e:
             raise AuthRespParsingException(

pyeudiw/satosa/default/request_handler.py

@@ -103,7 +103,7 @@ def request_endpoint(self, context: Context, *args) -> Response:
                 status="200",
                 content=RequestHandler._RESP_CONTENT_TYPE,
             )
-        except JWSSigningError as e500:
+        except Exception as e500:
             return self._handle_500(
                 context,
                 "internal error: error while processing the request object",

pyeudiw/tests/openid4vp/test_authorization_response.py

@@ -1,3 +1,4 @@
+import json
 import pytest
 import satosa.context
 
@@ -48,7 +49,7 @@ def test_direct_post_parser_good_case():
     ctx.request = {
         "vp_token": vp_token,
         "state": state,
-        "presentation_submission": presentation_submission,
+        "presentation_submission": json.dumps(presentation_submission),
     }
 
     resp = parser.parse_and_validate(ctx)
@@ -87,7 +88,7 @@ def test_direct_post_response_bad_parse_case():
     ctx.qs_params = {
         "vp_token": vp_token,
         "state": state,
-        "presentation_submission": presentation_submission,
+        "presentation_submission": json.dumps(presentation_submission),
     }
 
     try: