fix/517: checks on invalid categories

Author: AlexPalaz

src/app/components/EditorMultiselect.tsx

@@ -25,6 +25,12 @@ type Props<T> = {
 
 type PublicCodeData = PublicCode | PublicCodeWithDeprecatedFields;
 
+function filterValidValues(value: string[] | undefined, data: Array<{ value: string; text: string }>): string[] {
+  if (!value || !Array.isArray(value)) return [];
+  const validValues = data.map(item => item.value);
+  return value.filter(val => validValues.includes(val));
+}
+
 export default function EditorMultiselect<
   T extends FieldPathByValue<RequiredDeep<PublicCodeData>, Array<string>>
 >({ fieldName, required, data, filter, deprecated }: Props<T>): JSX.Element {
@@ -38,6 +44,14 @@ export default function EditorMultiselect<
   });
   const { t } = useTranslation();
 
+  const filteredValue = filterValidValues(value, data);
+  
+  useEffect(() => {
+    if (value && Array.isArray(value) && filteredValue.length !== value.length) {
+      onChange(filteredValue);
+    }
+  }, [value, filteredValue, onChange]);
+
   const label = t(`publiccodeyml.${fieldName}.label`);
   const description = t(`publiccodeyml.${fieldName}.description`);
   const errorMessage = get(errors, `${fieldName}.message`);
@@ -82,7 +96,7 @@ export default function EditorMultiselect<
           id={fieldName}
           onBlur={onBlur}
           onChange={(arr) => onChange(arr.map((e) => e.value))}
-          value={value}
+          value={filteredValue}
           data={data}
           dataKey="value"
           textField="text"

src/app/linter/index.ts

@@ -16,8 +16,13 @@ import PublicCode, {
   defaultPiattaforme,
   defaultRiuso,
 } from "../contents/publiccode";
+import categories from "../contents/categories";
 import { removeEmpty } from "./remove-empty";
 
+function validateCategories(categoriesArray: string[]): string[] {
+  return categoriesArray.filter(category => categories.includes(category as any));
+}
+
 function sortDescription({
   genericName,
   localisedName,
@@ -79,7 +84,7 @@ export default function linter({
     releaseDate,
     logo,
     platforms: clone(platforms),
-    categories: clone(categories),
+    categories: validateCategories(categories) as (typeof categories)[number][],
     usedBy: clone(usedBy),
     roadmap,
     developmentStatus,