feat: add deprecation warning for it.riuso.codiceIPA (#269)

Author: bfabio

fields.go

@@ -186,23 +186,45 @@ func validateFieldsV0(publiccode PublicCode, parser Parser, network bool) error
 		}
 	}
 
-	if (publiccodev0.It != nil && publiccodev0.It.Conforme != nil) ||
-		(publiccodev0.IT != nil && publiccodev0.IT.Conforme != nil) {
-		vr = append(vr, ValidationWarning{
-			"IT.conforme",
-			"This key is DEPRECATED and will be removed in the future. It's safe to drop it", 0, 0,
-		})
-	}
+	it := publiccodev0.IT
 
 	if publiccodev0.It != nil {
 		vr = append(vr, ValidationWarning{
 			"it",
 			"Lowercase country codes are DEPRECATED and will be removed in the future. Use 'IT' instead", 0, 0,
 		})
+
+		it = publiccodev0.It
 	}
 
 	if publiccodev0.IT != nil && publiccodev0.It != nil {
 		vr = append(vr, newValidationError("it", "'IT' key already present. Remove this key"))
+
+		it = publiccodev0.IT
+	}
+
+	if it != nil {
+		if it.Conforme != nil {
+			vr = append(vr, ValidationWarning{
+				"IT.conforme",
+				"This key is DEPRECATED and will be removed in the future. It's safe to drop it", 0, 0,
+			})
+		}
+
+		if it.Riuso.CodiceIPA != "" {
+			validate := publiccodeValidator.New()
+
+			if validate.Var(it.Riuso.CodiceIPA, "is_italian_ipa_code") == nil {
+				vr = append(vr, ValidationWarning{
+					"IT.riuso.codiceIPA",
+					fmt.Sprintf(
+						"This key is DEPRECATED and will be removed in the future. Use 'organisation.uri' and set it to 'urn:x-italian-pa:%s' instead",
+						it.Riuso.CodiceIPA,
+					),
+					0, 0,
+				})
+			}
+		}
 	}
 
 	if len(vr) == 0 {

parser_test.go

@@ -626,8 +626,8 @@ func TestInvalidTestcasesV0(t *testing.T) {
 			ValidationError{"IT.riuso.codiceIPA", "codiceIPA must be a valid Italian Public Administration Code (iPA) (see https://www.indicepa.gov.it/public-services/opendata-read-service.php?dstype=FS&filename=amministrazioni.txt)", 55, 5},
 		},
 		"it_IT_duplicated.yml": ValidationResults{
-			ValidationWarning{"it", "Lowercase country codes are DEPRECATED and will be removed in the future. Use 'IT' instead", 119, 1},
-			ValidationError{"it", "'IT' key already present. Remove this key", 119, 1},
+			ValidationWarning{"it", "Lowercase country codes are DEPRECATED and will be removed in the future. Use 'IT' instead", 116, 1},
+			ValidationError{"it", "'IT' key already present. Remove this key", 116, 1},
 		},
 		"it_wrong_case.yml": ValidationResults{
 			ValidationError{"It", "field It not found in type publiccode.PublicCodeV0", 107, 1},
@@ -712,6 +712,9 @@ func TestValidWithWarningsTestcasesV0(t *testing.T) {
 		"valid_with_legal_repoOwner.yml": ValidationResults{
 			ValidationWarning{"legal.repoOwner", "This key is DEPRECATED and will be removed in the future. Use 'organisation.name' instead", 70, 3},
 		},
+		"valid_with_IT_riuso_codiceIPA.yml": ValidationResults{
+			ValidationWarning{"IT.riuso.codiceIPA", "This key is DEPRECATED and will be removed in the future. Use 'organisation.uri' and set it to 'urn:x-italian-pa:pcm' instead", 119, 5},
+		},
 	}
 
 	dir := "testdata/v0/valid_with_warnings/"

testdata/v0/invalid/it_IT_duplicated.yml

@@ -107,9 +107,6 @@ dependsOn:
 IT:
   countryExtensionVersion: "1.0"
 
-  riuso:
-    codiceIPA: c_h501
-
   piattaforme:
     spid: false
     pagopa: false
@@ -119,9 +116,6 @@ IT:
 it:
   countryExtensionVersion: "1.0"
 
-  riuso:
-    codiceIPA: c_h501
-
   piattaforme:
     spid: false
     pagopa: false

testdata/v0/invalid/it_wrong_case.yml

@@ -107,9 +107,6 @@ dependsOn:
 It:
   countryExtensionVersion: "1.0"
 
-  riuso:
-    codiceIPA: c_h501
-
   piattaforme:
     spid: false
     pagopa: false

testdata/v0/invalid/landingURL_invalid.yml

@@ -118,9 +118,6 @@ dependsOn:
       optional: true
 
 IT:
-  riuso:
-    codiceIPA: c_h501
-
   piattaforme:
     spid: true
     pagopa: true

testdata/v0/invalid/landingURL_wrong_type.yml

@@ -114,9 +114,6 @@ dependsOn:
       optional: true
 
 IT:
-  riuso:
-    codiceIPA: c_h501
-
   piattaforme:
     spid: true
     pagopa: true

testdata/v0/invalid/no-network/landingURL_invalid.yml

@@ -118,9 +118,6 @@ dependsOn:
       optional: true
 
 IT:
-  riuso:
-    codiceIPA: c_h501
-
   piattaforme:
     spid: true
     pagopa: true

testdata/v0/valid/countryExtensionVersion_1.0.yml

@@ -106,9 +106,6 @@ dependsOn:
 IT:
   countryExtensionVersion: "1.0"
 
-  riuso:
-    codiceIPA: c_h501
-
   piattaforme:
     spid: false
     pagopa: false

testdata/v0/valid/dependsOn.yml

@@ -110,10 +110,6 @@ dependsOn: # List of dependencies. The only mandatory list is the proprietary on
 IT:
   countryExtensionVersion: "0.2"
 
-  riuso:
-    # Codice IPA della PA che ha pubblicato questo repo (repo-owner)
-    codiceIPA: c_h501
-
   piattaforme:
     spid: false
     pagopa: false

testdata/v0/valid/no-network/valid.yml

@@ -226,9 +226,6 @@ dependsOn:
       optional: true
 
 IT:
-  riuso:
-    codiceIPA: c_h501
-
   piattaforme:
     spid: true
     pagopa: true