Skip to content

Commit a17ccbd

Browse files
authored
feat!: deprecate it.conforme (#261)
See publiccodeyml/publiccode.yml#223
1 parent 95477a9 commit a17ccbd

File tree

13 files changed

+382
-160
lines changed

13 files changed

+382
-160
lines changed

fields.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,13 @@ func validateFieldsV0(publiccode PublicCode, parser Parser, network bool) error
138138
}
139139
}
140140

141+
if publiccodev0.It != nil && publiccodev0.It.Conforme != nil {
142+
vr = append(vr, ValidationWarning{
143+
"it.conforme",
144+
"This key is DEPRECATED and will be removed in the future. It's safe to drop it", 0, 0,
145+
})
146+
}
147+
141148
if len(vr) == 0 {
142149
return nil
143150
}

parser_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -684,6 +684,9 @@ func TestValidWithWarningsTestcasesV0(t *testing.T) {
684684
ValidationWarning{"inputTypes", "This key is DEPRECATED and will be removed in the future. It's safe to drop it", 48, 1},
685685
ValidationWarning{"outputTypes", "This key is DEPRECATED and will be removed in the future. It's safe to drop it", 50, 1},
686686
},
687+
"valid_with_it_conforme.yml": ValidationResults{
688+
ValidationWarning{"it.conforme", "This key is DEPRECATED and will be removed in the future. It's safe to drop it", 120, 3},
689+
},
687690
}
688691

689692
dir := "testdata/v0/valid_with_warnings/"

testdata/v0/invalid/landingURL_invalid.yml

Lines changed: 20 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -40,34 +40,34 @@ description:
4040
localisedName: Medusa
4141
shortDescription: "A really interesting software."
4242
longDescription: >
43-
Very long description of this software, also split
44-
on multiple rows. You should note what the software
45-
is and why one should need it. This is 158 characters.
46-
Very long description of this software, also split
47-
on multiple rows. You should note what the software
48-
is and why one should need it. This is 316 characters.
49-
Very long description of this software, also split
50-
on multiple rows. You should note what the software
51-
is and why one should need it. This is 474 characters.
52-
Very long description of this software, also split
53-
on multiple rows. You should note what the software
54-
is and why one should need it. This is 632 characters.
43+
Very long description of this software, also split
44+
on multiple rows. You should note what the software
45+
is and why one should need it. This is 158 characters.
46+
Very long description of this software, also split
47+
on multiple rows. You should note what the software
48+
is and why one should need it. This is 316 characters.
49+
Very long description of this software, also split
50+
on multiple rows. You should note what the software
51+
is and why one should need it. This is 474 characters.
52+
Very long description of this software, also split
53+
on multiple rows. You should note what the software
54+
is and why one should need it. This is 632 characters.
5555
5656
documentation: "https://docs.italia.it"
5757
apiDocumentation: "https://developers.italia.it/it/api"
5858

5959
features:
60-
- Very important feature
61-
- Will run without a problem
62-
- Has zero bugs
63-
- Solves all the problems of the world
64-
videos: # Demo videos of the software
65-
- https://www.youtube.com/watch?v=RaHmGbBOP84
60+
- Very important feature
61+
- Will run without a problem
62+
- Has zero bugs
63+
- Solves all the problems of the world
64+
videos: # Demo videos of the software
65+
- https://www.youtube.com/watch?v=RaHmGbBOP84
6666
awards:
67-
- 1st Price Software of the year
67+
- 1st Price Software of the year
6868

6969
legal:
70-
license: AGPL-3.0-or-later # SPDX expression of license
70+
license: AGPL-3.0-or-later # SPDX expression of license
7171
mainCopyrightOwner: City of Chicago
7272
repoOwner: City of Chicago
7373

@@ -119,12 +119,6 @@ dependsOn:
119119
optional: true
120120

121121
it:
122-
conforme:
123-
lineeGuidaDesign: true
124-
modelloInteroperabilita: true
125-
misureMinimeSicurezza: true
126-
gdpr: true
127-
128122
riuso:
129123
codiceIPA: c_h501
130124

testdata/v0/invalid/landingURL_wrong_type.yml

Lines changed: 17 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -40,30 +40,30 @@ description:
4040
localisedName: Medusa
4141
shortDescription: "A really interesting software."
4242
longDescription: >
43-
Very long description of this software, also split
44-
on multiple rows. You should note what the software
45-
is and why one should need it. This is 158 characters.
46-
Very long description of this software, also split
47-
on multiple rows. You should note what the software
48-
is and why one should need it. This is 316 characters.
49-
Very long description of this software, also split
50-
on multiple rows. You should note what the software
51-
is and why one should need it. This is 474 characters.
52-
Very long description of this software, also split
53-
on multiple rows. You should note what the software
54-
is and why one should need it. This is 632 characters.
43+
Very long description of this software, also split
44+
on multiple rows. You should note what the software
45+
is and why one should need it. This is 158 characters.
46+
Very long description of this software, also split
47+
on multiple rows. You should note what the software
48+
is and why one should need it. This is 316 characters.
49+
Very long description of this software, also split
50+
on multiple rows. You should note what the software
51+
is and why one should need it. This is 474 characters.
52+
Very long description of this software, also split
53+
on multiple rows. You should note what the software
54+
is and why one should need it. This is 632 characters.
5555
5656
documentation: "https://docs.italia.it"
5757
apiDocumentation: "https://developers.italia.it/it/api"
5858

5959
features:
60-
- Very important feature
61-
- Will run without a problem
62-
- Has zero bugs
63-
- Solves all the problems of the world
60+
- Very important feature
61+
- Will run without a problem
62+
- Has zero bugs
63+
- Solves all the problems of the world
6464

6565
legal:
66-
license: AGPL-3.0-or-later # SPDX expression of license
66+
license: AGPL-3.0-or-later # SPDX expression of license
6767
mainCopyrightOwner: City of Chicago
6868
repoOwner: City of Chicago
6969

@@ -115,12 +115,6 @@ dependsOn:
115115
optional: true
116116

117117
it:
118-
conforme:
119-
lineeGuidaDesign: true
120-
modelloInteroperabilita: true
121-
misureMinimeSicurezza: true
122-
gdpr: true
123-
124118
riuso:
125119
codiceIPA: c_h501
126120

testdata/v0/invalid/no-network/landingURL_invalid.yml

Lines changed: 20 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -40,34 +40,34 @@ description:
4040
localisedName: Medusa
4141
shortDescription: "A really interesting software."
4242
longDescription: >
43-
Very long description of this software, also split
44-
on multiple rows. You should note what the software
45-
is and why one should need it. This is 158 characters.
46-
Very long description of this software, also split
47-
on multiple rows. You should note what the software
48-
is and why one should need it. This is 316 characters.
49-
Very long description of this software, also split
50-
on multiple rows. You should note what the software
51-
is and why one should need it. This is 474 characters.
52-
Very long description of this software, also split
53-
on multiple rows. You should note what the software
54-
is and why one should need it. This is 632 characters.
43+
Very long description of this software, also split
44+
on multiple rows. You should note what the software
45+
is and why one should need it. This is 158 characters.
46+
Very long description of this software, also split
47+
on multiple rows. You should note what the software
48+
is and why one should need it. This is 316 characters.
49+
Very long description of this software, also split
50+
on multiple rows. You should note what the software
51+
is and why one should need it. This is 474 characters.
52+
Very long description of this software, also split
53+
on multiple rows. You should note what the software
54+
is and why one should need it. This is 632 characters.
5555
5656
documentation: "https://docs.italia.it"
5757
apiDocumentation: "https://developers.italia.it/it/api"
5858

5959
features:
60-
- Very important feature
61-
- Will run without a problem
62-
- Has zero bugs
63-
- Solves all the problems of the world
64-
videos: # Demo videos of the software
65-
- https://www.youtube.com/watch?v=RaHmGbBOP84
60+
- Very important feature
61+
- Will run without a problem
62+
- Has zero bugs
63+
- Solves all the problems of the world
64+
videos: # Demo videos of the software
65+
- https://www.youtube.com/watch?v=RaHmGbBOP84
6666
awards:
67-
- 1st Price Software of the year
67+
- 1st Price Software of the year
6868

6969
legal:
70-
license: AGPL-3.0-or-later # SPDX expression of license
70+
license: AGPL-3.0-or-later # SPDX expression of license
7171
mainCopyrightOwner: City of Chicago
7272
repoOwner: City of Chicago
7373

@@ -119,12 +119,6 @@ dependsOn:
119119
optional: true
120120

121121
it:
122-
conforme:
123-
lineeGuidaDesign: true
124-
modelloInteroperabilita: true
125-
misureMinimeSicurezza: true
126-
gdpr: true
127-
128122
riuso:
129123
codiceIPA: c_h501
130124

testdata/v0/valid/countryExtensionVersion_1.0.yml

Lines changed: 19 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -38,31 +38,31 @@ description:
3838
localisedName: Medusa
3939
shortDescription: "A really interesting software."
4040
longDescription: >
41-
Very long description of this software, also split
42-
on multiple rows. You should note what the software
43-
is and why one should need it. This is 158 characters.
44-
Very long description of this software, also split
45-
on multiple rows. You should note what the software
46-
is and why one should need it. This is 316 characters.
47-
Very long description of this software, also split
48-
on multiple rows. You should note what the software
49-
is and why one should need it. This is 474 characters.
50-
Very long description of this software, also split
51-
on multiple rows. You should note what the software
52-
is and why one should need it. This is 632 characters.
41+
Very long description of this software, also split
42+
on multiple rows. You should note what the software
43+
is and why one should need it. This is 158 characters.
44+
Very long description of this software, also split
45+
on multiple rows. You should note what the software
46+
is and why one should need it. This is 316 characters.
47+
Very long description of this software, also split
48+
on multiple rows. You should note what the software
49+
is and why one should need it. This is 474 characters.
50+
Very long description of this software, also split
51+
on multiple rows. You should note what the software
52+
is and why one should need it. This is 632 characters.
5353
5454
documentation: "https://docs.italia.it"
5555
apiDocumentation: "https://developers.italia.it/it/api"
5656

5757
features:
58-
- Very important feature
59-
- Will run without a problem
60-
- Has zero bugs
61-
- Solves all the problems of the world
58+
- Very important feature
59+
- Will run without a problem
60+
- Has zero bugs
61+
- Solves all the problems of the world
6262
videos:
63-
- https://www.youtube.com/watch?v=RaHmGbBOP84
63+
- https://www.youtube.com/watch?v=RaHmGbBOP84
6464
awards:
65-
- 1st Price Software of the year
65+
- 1st Price Software of the year
6666

6767
legal:
6868
license: AGPL-3.0-or-later
@@ -74,7 +74,7 @@ maintenance:
7474
contacts:
7575
7676
name: Mario Rossi
77-
phone: '+390412501953'
77+
phone: "+390412501953"
7878

7979
localisation:
8080
localisationReady: true
@@ -106,11 +106,6 @@ dependsOn:
106106

107107
it:
108108
countryExtensionVersion: "1.0"
109-
conforme:
110-
lineeGuidaDesign: false
111-
modelloInteroperabilita: false
112-
misureMinimeSicurezza: false
113-
gdpr: false
114109

115110
riuso:
116111
codiceIPA: c_h501

0 commit comments

Comments
 (0)