add sync modes for copy and delete, always use background context instead of request context

Author: leafo

README.md

@@ -141,6 +141,10 @@ zipserver copy --key path/to/file.zip --target s3backup
 
 **HTTP API:**
 ```bash
+# Sync mode (waits for completion)
+curl "http://localhost:8090/copy?key=path/to/file.zip&target=s3backup"
+
+# Async mode (returns immediately, notifies callback when done)
 curl "http://localhost:8090/copy?key=path/to/file.zip&target=s3backup&callback=http://example.com/done"
 ```
 
@@ -155,6 +159,13 @@ zipserver delete --key file1.zip --key file2.zip --target s3backup
 
 **HTTP API:**
 ```bash
+# Sync mode (waits for completion)
+curl -X POST "http://localhost:8090/delete" \
+  -d "keys[]=file1.zip" \
+  -d "keys[]=file2.zip" \
+  -d "target=s3backup"
+
+# Async mode (returns immediately, notifies callback when done)
 curl -X POST "http://localhost:8090/delete" \
   -d "keys[]=file1.zip" \
   -d "keys[]=file2.zip" \
@@ -265,8 +276,8 @@ Some HTTP handlers support callbacks to notify your application when long-runnin
 |----------|-----------|---------------------|
 | `/extract` | `async` | Yes (omit `async` for sync) |
 | `/slurp` | `async` | Yes (omit `async` for sync) |
-| `/copy` | `callback` | No (always async) |
-| `/delete` | `callback` | No (always async) |
+| `/copy` | `callback` | Yes (omit `callback` for sync) |
+| `/delete` | `callback` | Yes (omit `callback` for sync) |
 
 ### How It Works
 

zipserver/copy_handler.go

@@ -144,10 +144,7 @@ func copyHandler(w http.ResponseWriter, r *http.Request) error {
 		return err
 	}
 
-	callbackURL, err := getParam(params, "callback")
-	if err != nil {
-		return err
-	}
+	callbackURL := params.Get("callback")
 
 	targetName, err := getParam(params, "target")
 	if err != nil {
@@ -177,6 +174,28 @@ func copyHandler(w http.ResponseWriter, r *http.Request) error {
 		ExpectedBucket: expectedBucket,
 	}
 
+	// sync codepath
+	if callbackURL == "" {
+		defer copyLockTable.releaseKey(lockKey)
+
+		ctx, cancel := context.WithTimeout(context.Background(), time.Duration(globalConfig.JobTimeout))
+		defer cancel()
+
+		result := ops.Copy(ctx, copyParams)
+		if result.Err != nil {
+			return writeJSONError(w, "CopyError", result.Err)
+		}
+
+		return writeJSONMessage(w, struct {
+			Success  bool
+			Key      string
+			Duration string
+			Size     int64
+			Md5      string
+		}{true, result.Key, result.Duration, result.Size, result.Md5})
+	}
+
+	// async codepath
 	go (func() {
 		defer copyLockTable.releaseKey(lockKey)
 

zipserver/delete_handler.go

@@ -210,10 +210,7 @@ func deleteHandler(w http.ResponseWriter, r *http.Request) error {
 
 	params := r.Form
 
-	callbackURL, err := getParam(params, "callback")
-	if err != nil {
-		return err
-	}
+	callbackURL := params.Get("callback")
 
 	// target is optional; if not provided, delete from primary storage (restricted to ExtractPrefix)
 	// Validation of target and prefix constraints is handled by Operations.Delete
@@ -225,6 +222,25 @@ func deleteHandler(w http.ResponseWriter, r *http.Request) error {
 		TargetName: targetName,
 	}
 
+	// sync codepath
+	if callbackURL == "" {
+		ctx, cancel := context.WithTimeout(context.Background(), time.Duration(globalConfig.JobTimeout))
+		defer cancel()
+
+		result := ops.Delete(ctx, deleteParams)
+		if result.Err != nil {
+			return writeJSONError(w, "DeleteError", result.Err)
+		}
+
+		return writeJSONMessage(w, struct {
+			Success     bool
+			TotalKeys   int
+			DeletedKeys int
+			Errors      []DeleteError
+		}{len(result.Errors) == 0, result.TotalKeys, result.DeletedKeys, result.Errors})
+	}
+
+	// async codepath
 	go func() {
 		jobCtx, cancel := context.WithTimeout(context.Background(), time.Duration(globalConfig.JobTimeout))
 		defer cancel()

zipserver/extract_handler.go

@@ -182,8 +182,8 @@ func extractHandler(w http.ResponseWriter, r *http.Request) error {
 	if asyncURL == "" {
 		defer extractLockTable.releaseKey(lockKey)
 
-			ctx, cancel := context.WithTimeout(r.Context(), time.Duration(globalConfig.JobTimeout))
-			defer cancel()
+		ctx, cancel := context.WithTimeout(context.Background(), time.Duration(globalConfig.JobTimeout))
+		defer cancel()
 
 		result := ops.Extract(ctx, extractParams)
 		if result.Err != nil {

zipserver/slurp_handler.go

@@ -159,7 +159,7 @@ func slurpHandler(w http.ResponseWriter, r *http.Request) error {
 
 	asyncURL := params.Get("async")
 	if asyncURL == "" {
-		ctx, cancel := context.WithTimeout(r.Context(), time.Duration(globalConfig.JobTimeout))
+		ctx, cancel := context.WithTimeout(context.Background(), time.Duration(globalConfig.JobTimeout))
 		defer cancel()
 
 		err = process(ctx)