Skip to content

Commit 09ce388

Browse files
authored
Merge pull request #17347 from iterate-ch/bugfix/GH-17344
Include VC140 dependency
2 parents 896157c + 045f0dc commit 09ce388

File tree

5 files changed

+33
-1
lines changed

5 files changed

+33
-1
lines changed

cli/src/main/csharp/duck.csproj

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@
2424
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
2525
<Link>$(Filename)$(Extension)</Link>
2626
</Content>
27+
<Content Include="$(TargetBuildDir)lib\vcruntime140*.dll">
28+
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
29+
<Link>$(Filename)$(Extension)</Link>
30+
</Content>
2731

2832
<Content Include="$(CyberduckDir)bookmarks/*.duck">
2933
<Link>bookmarks/%(Filename)%(Extension)</Link>

cli/src/main/wix/Bundle/Cyberduck CLI-WiX.wxs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,12 @@
9292
<Component Id="jnidispatch" Guid="B6621775-1A9A-461E-83B8-BB1EE34B5965">
9393
<File Source="$(var.CLI.TargetDir)/jnidispatch.dll" KeyPath="yes" Checksum="yes"/>
9494
</Component>
95+
<Component Id="vcruntime140">
96+
<File Source="$(var.CLI.TargetDir)/vcruntime140.dll" KeyPath="yes" Checksum="yes"/>
97+
</Component>
98+
<Component Id="vcruntime140_1">
99+
<File Source="$(var.CLI.TargetDir)/vcruntime140_1.dll" KeyPath="yes" Checksum="yes"/>
100+
</Component>
95101

96102
<Component Id="System.Buffers">
97103
<File Source="$(var.CLI.TargetDir)/System.Buffers.dll" KeyPath="yes" Checksum="yes" />

core/dll/pom.xml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,22 @@
102102
<version>${jna-version}</version>
103103
<scope>runtime</scope>
104104
</dependency>
105+
<dependency>
106+
<groupId>com.microsoft</groupId>
107+
<artifactId>vcruntime140</artifactId>
108+
<classifier>x64</classifier>
109+
<type>dll</type>
110+
<version>14.44.35211</version>
111+
<scope>runtime</scope>
112+
</dependency>
113+
<dependency>
114+
<groupId>com.microsoft</groupId>
115+
<artifactId>vcruntime140_1</artifactId>
116+
<classifier>x64</classifier>
117+
<type>dll</type>
118+
<version>14.44.35211</version>
119+
<scope>runtime</scope>
120+
</dependency>
105121
</dependencies>
106122
</profile>
107123
</profiles>

windows/src/main/csharp/Cyberduck.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
</ItemGroup>
2020

2121
<ItemGroup>
22-
<Content Include="$(TargetBuildDir)lib\jnidispatch.dll;$(TargetBuildDir)lib\winsparkle.dll">
22+
<Content Include="$(TargetBuildDir)lib\jnidispatch.dll;$(TargetBuildDir)lib\winsparkle.dll;$(TargetBuildDir)lib\vcruntime140*.dll">
2323
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
2424
<Link>$(Filename)$(Extension)</Link>
2525
</Content>

windows/src/main/wix/Bundle/Cyberduck.wxs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,12 @@
131131
<Component Id="jnidispatch">
132132
<File Source="$(var.cyberduck.TargetDir)/jnidispatch.dll" KeyPath="yes" Checksum="yes" />
133133
</Component>
134+
<Component Id="vcruntime140">
135+
<File Source="$(var.cyberduck.TargetDir)/vcruntime140.dll" KeyPath="yes" Checksum="yes" />
136+
</Component>
137+
<Component Id="vcruntime140_1">
138+
<File Source="$(var.cyberduck.TargetDir)/vcruntime140_1.dll" KeyPath="yes" Checksum="yes" />
139+
</Component>
134140

135141
<!-- IKVM -->
136142
<Component Id="IKVM.ByteCode.dll">

0 commit comments

Comments
 (0)