Skip to content

Commit 286cf3b

Browse files
committed
Always create new controller when displayed in popover.
1 parent c8ae596 commit 286cf3b

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

osx/src/main/java/ch/cyberduck/ui/cocoa/controller/BookmarkControllerFactory.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,17 @@
1818
import ch.cyberduck.binding.application.NSApplication;
1919
import ch.cyberduck.core.AbstractHostCollection;
2020
import ch.cyberduck.core.Host;
21+
import ch.cyberduck.core.preferences.Preferences;
22+
import ch.cyberduck.core.preferences.PreferencesFactory;
2123

2224
import java.util.HashMap;
2325
import java.util.Map;
2426

2527
public final class BookmarkControllerFactory {
2628

29+
private static final Preferences preferences
30+
= PreferencesFactory.get();
31+
2732
private static final Map<Host, BookmarkContainerController> open
2833
= new HashMap<>();
2934

@@ -33,7 +38,7 @@ private BookmarkControllerFactory() {
3338

3439
public static BookmarkContainerController create(final AbstractHostCollection collection, final Host host) {
3540
synchronized(NSApplication.sharedApplication()) {
36-
if(!open.containsKey(host)) {
41+
if(!open.containsKey(host) || preferences.getBoolean("bookmark.window.popover")) {
3742
final BookmarkContainerController c = new ExtendedBookmarkController(host, collection) {
3843
@Override
3944
public void invalidate() {

0 commit comments

Comments
 (0)