Merge pull request #17610 from iterate-ch/bugfix/MD-25631

dkocher · web-flow · commit 8d368125640e · 2025-11-03T07:38:46.000+01:00
Skip authentication attempt for unknown key file such as .pub
diff --git a/ssh/src/main/java/ch/cyberduck/core/sftp/auth/SFTPPublicKeyAuthentication.java b/ssh/src/main/java/ch/cyberduck/core/sftp/auth/SFTPPublicKeyAuthentication.java
@@ -107,7 +107,7 @@ public Boolean authenticate(final Host bookmark, final LoginCallback prompt, fin
                         break;
                     default:
                         log.warn("Unknown key format for file {}", privKey.getName());
-                        throw new LoginFailureException(String.format("Unknown key format for file %s", privKey.getName()));
+                        return false;
                 }
                 provider.init(new InputStreamReader(privKey.getInputStream(), StandardCharsets.UTF_8),
                         pubKey != null ? new InputStreamReader(pubKey.getInputStream(), StandardCharsets.UTF_8) : null,

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ public Boolean authenticate(final Host bookmark, final LoginCallback prompt, fin`
`107`	`107`	`break;`
`108`	`108`	`default:`
`109`	`109`	`log.warn("Unknown key format for file {}", privKey.getName());`
`110`		`- throw new LoginFailureException(String.format("Unknown key format for file %s", privKey.getName()));`
	`110`	`+ return false;`
`111`	`111`	`}`
`112`	`112`	`provider.init(new InputStreamReader(privKey.getInputStream(), StandardCharsets.UTF_8),`
`113`	`113`	`pubKey != null ? new InputStreamReader(pubKey.getInputStream(), StandardCharsets.UTF_8) : null,`