Make string -> PCWSTR -> PWSTR dangerous

Author: AliveDevil

core/src/main/csharp/Windows/Win32/Foundation_PWSTR_Extensions.cs

@@ -0,0 +1,10 @@
+using Windows.Win32.Foundation;
+
+namespace Windows.Win32;
+
+public static partial class Foundation_PWSTR_Extensions
+{
+
+    public static unsafe PWSTR DangerousAsPWSTR(this in PCWSTR pwstr) => pwstr.Value;
+
+}

core/src/main/csharp/Windows/Win32/PWSTR.cs

@@ -6,12 +6,10 @@ namespace Windows.Win32.Foundation;
 
 public unsafe partial struct PWSTR
 {
-    public static PWSTR DangerousFromString(in ReadOnlySpan<char> value)
+    public static PWSTR DangerousFromString(in Span<char> value)
     {
         return (char*)Unsafe.AsPointer(ref MemoryMarshal.GetReference(value));
     }
 
-    public static PWSTR DangerousFromString(string value) => DangerousFromString(value.AsSpan());
-
     public string ToString(int length) => Value is null ? null : new(Value, 0, length);
 }

core/src/main/csharp/ch/cyberduck/core/credentialmanager/WinCredentialManager.cs

@@ -24,6 +24,7 @@
 using System.Net;
 using System.Runtime.InteropServices;
 using System.Text;
+using Windows.Win32;
 using Windows.Win32.Foundation;
 using Windows.Win32.Security.Credentials;
 using static System.Runtime.CompilerServices.Unsafe;
@@ -142,8 +143,8 @@ public static unsafe bool SaveCredentials(string target, WindowsCredentialManage
         {
             var cred = new CREDENTIALW
             {
-                TargetName = PWSTR.DangerousFromString(target),
-                UserName = PWSTR.DangerousFromString(credential.UserName),
+                TargetName = PCWSTR.DangerousFromString(target).DangerousAsPWSTR(),
+                UserName = PCWSTR.DangerousFromString(credential.UserName).DangerousAsPWSTR(),
                 Type = credential.Type,
                 Flags = credential.Flags,
                 Persist = credential.Persist,
@@ -178,7 +179,7 @@ public static unsafe bool SaveCredentials(string target, WindowsCredentialManage
                     var key = string.Format(formatString, item.Key, innerIndex);
                     attributes.Memory.Span[index] = new CREDENTIAL_ATTRIBUTEW()
                     {
-                        Keyword = PWSTR.DangerousFromString(key),
+                        Keyword = PCWSTR.DangerousFromString(key).DangerousAsPWSTR(),
                         ValueSize = (uint)length,
                         Value = ((byte*)wstr.Value) + i
                     };

core/src/main/csharp/ch/cyberduck/core/local/ShellApplicationFinder.cs

@@ -232,7 +232,7 @@ public class ProgIdApplication : Application, IInvokeApplication, WindowsApplica
         {
             public ProgIdApplication(string identifier, string name, string defaultIcon) : base(identifier, name)
             {
-                PWSTR pszIconFile = PWSTR.DangerousFromString(defaultIcon);
+                PWSTR pszIconFile = PCWSTR.DangerousFromString(defaultIcon).DangerousAsPWSTR();
                 IconIndex = PathParseIconLocation(pszIconFile);
                 IconPath = pszIconFile.ToString();
             }