Skip to content

Commit ea6937a

Browse files
committed
Logging.
1 parent 1f2020b commit ea6937a

File tree

4 files changed

+16
-1
lines changed

4 files changed

+16
-1
lines changed

cli/src/main/java/ch/cyberduck/cli/TerminalAlertCallback.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,17 @@
2424
import ch.cyberduck.core.threading.AlertCallback;
2525
import ch.cyberduck.core.threading.DefaultFailureDiagnostics;
2626

27+
import org.apache.logging.log4j.LogManager;
28+
import org.apache.logging.log4j.Logger;
29+
2730
public class TerminalAlertCallback implements AlertCallback {
31+
private static final Logger log = LogManager.getLogger(TerminalAlertCallback.class);
2832

2933
private final Console console = new Console();
3034

3135
@Override
3236
public boolean alert(final Host host, final BackgroundException failure) {
37+
log.warn("Notify for failure {}", failure.toString());
3338
this.print(failure);
3439
// Never repeat
3540
return false;

core/src/main/java/ch/cyberduck/core/notification/NotificationAlertCallback.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,17 @@
2323
import ch.cyberduck.core.exception.BackgroundException;
2424
import ch.cyberduck.core.threading.AlertCallback;
2525

26+
import org.apache.logging.log4j.LogManager;
27+
import org.apache.logging.log4j.Logger;
28+
2629
public class NotificationAlertCallback implements AlertCallback {
30+
private static final Logger log = LogManager.getLogger(NotificationAlertCallback.class);
2731

2832
private final NotificationService notification = NotificationServiceFactory.get();
2933

3034
@Override
3135
public boolean alert(final Host bookmark, final BackgroundException failure) {
36+
log.warn("Notify for failure {}", failure.toString());
3237
notification.notify(BookmarkNameProvider.toString(bookmark), bookmark.getUuid(), failure.getMessage(), BookmarkNameProvider.toString(bookmark));
3338
return false;
3439
}

core/src/main/java/ch/cyberduck/core/threading/DisabledAlertCallback.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public class DisabledAlertCallback implements AlertCallback {
2929

3030
@Override
3131
public boolean alert(final Host host, final BackgroundException failure) {
32-
log.warn("Ignore failure {}", failure.getMessage());
32+
log.warn("Ignore failure {}", failure.toString());
3333
return false;
3434
}
3535
}

osx/src/main/java/ch/cyberduck/ui/cocoa/callback/PromptAlertCallback.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,11 @@
2929
import ch.cyberduck.core.threading.FailureDiagnostics;
3030
import ch.cyberduck.ui.cocoa.controller.BackgroundExceptionAlertController;
3131

32+
import org.apache.logging.log4j.LogManager;
33+
import org.apache.logging.log4j.Logger;
34+
3235
public class PromptAlertCallback implements AlertCallback {
36+
private static final Logger log = LogManager.getLogger(PromptAlertCallback.class);
3337

3438
private final ProxyController controller;
3539
private final NotificationAlertCallback notification = new NotificationAlertCallback();
@@ -40,6 +44,7 @@ public PromptAlertCallback(final ProxyController controller) {
4044

4145
@Override
4246
public boolean alert(final Host host, final BackgroundException failure) {
47+
log.warn("Notify for failure {}", failure.toString());
4348
final FailureDiagnostics.Type type = new DefaultFailureDiagnostics().determine(failure);
4449
switch(type) {
4550
case cancel:

0 commit comments

Comments
 (0)