Remove interceptors for STS and simplify token handling setup #17614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkocher
force-pushed
the
bugfix/GH-17437-savedtokens
branch
from
debe32a to
ca4a31a
Compare
dkocher
force-pushed
the
bugfix/GH-17437-savedtokens
branch
from
46838ec to
9c7e1cc
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 40 out of 40 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
s3/src/main/java/ch/cyberduck/core/sts/STSCredentialsStrategy.java:63
- The
refresh()method is called while holding the lock, which could block other threads if the refresh operation takes time (e.g., network calls to STS). Consider releasing the lock before making the network call or documenting that callers should expect potential delays.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
oauth/src/main/java/ch/cyberduck/core/oauth/OAuth2RequestInterceptor.java
Show resolved
Hide resolved
oauth/src/main/java/ch/cyberduck/core/oauth/OAuth2ErrorResponseInterceptor.java
Show resolved
Hide resolved
ylangisc
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.