Increase shared buffer size for diagnostic logging. This hsould be fine since its shared.

Author: wasabii

src/IKVM.CoreLib/Buffers/MemoryBufferWriter.cs

@@ -177,17 +177,13 @@ public Span<T> GetSpan(int sizeHint = 0)
         void CheckBuffer(int sizeHint)
         {
             if (sizeHint < 0)
-                throw new ArgumentException(nameof(sizeHint));
+                throw new ArgumentException("SizeHint must be greater than or equal to zero.", nameof(sizeHint));
 
             if (sizeHint == 0)
-            {
                 sizeHint = 1;
-            }
 
             if (sizeHint > FreeCapacity)
-            {
                 throw new InvalidOperationException("Buffer size is lower than requested.");
-            }
 
             Debug.Assert(FreeCapacity > 0 && FreeCapacity >= sizeHint);
         }

src/IKVM.CoreLib/Diagnostics/JsonDiagnosticFormat.cs

@@ -29,7 +29,7 @@ static class JsonDiagnosticFormat
         /// <param name="writer"></param>
         public static void Write(int id, DiagnosticLevel level, string message, object?[] args, Exception? exception, DiagnosticLocation location, TextWriter writer)
         {
-            var buffer = MemoryPool<byte>.Shared.Rent(8192);
+            var buffer = MemoryPool<byte>.Shared.Rent(65535);
 
             try
             {
@@ -55,7 +55,7 @@ public static void Write(int id, DiagnosticLevel level, string message, object?[
         /// <param name="writer"></param>
         public static async ValueTask WriteAsync(int id, DiagnosticLevel level, string message, object?[] args, Exception? exception, DiagnosticLocation location, TextWriter writer, CancellationToken cancellationToken)
         {
-            var buffer = MemoryPool<byte>.Shared.Rent(8192);
+            var buffer = MemoryPool<byte>.Shared.Rent(65535);
 
             try
             {
@@ -95,7 +95,7 @@ public static void Write<TWriter>(int id, DiagnosticLevel level, string message,
                 // if we're not writing UTF8, stage to a temporary buffer
                 if (encoding is not UTF8Encoding)
                 {
-                    mem = MemoryPool<byte>.Shared.Rent(8192);
+                    mem = MemoryPool<byte>.Shared.Rent(65535);
                     buf = new MemoryBufferWriter<byte>(mem.Memory);
                 }
 

src/IKVM.CoreLib/Diagnostics/TextDiagnosticFormat.cs

@@ -29,7 +29,7 @@ static class TextDiagnosticFormat
         /// <param name="writer"></param>
         public static void Write(int id, DiagnosticLevel level, string message, object?[] args, Exception? exception, DiagnosticLocation location, TextWriter writer)
         {
-            var buffer = MemoryPool<byte>.Shared.Rent(8192);
+            var buffer = MemoryPool<byte>.Shared.Rent(65535);
 
             try
             {
@@ -56,7 +56,7 @@ public static void Write(int id, DiagnosticLevel level, string message, object?[
         /// <param name="cancellationToken"></param>
         public static async ValueTask WriteAsync(int id, DiagnosticLevel level, string message, object?[] args, Exception? exception, DiagnosticLocation location, TextWriter writer, CancellationToken cancellationToken)
         {
-            var buffer = MemoryPool<byte>.Shared.Rent(8192);
+            var buffer = MemoryPool<byte>.Shared.Rent(65535);
 
             try
             {

src/IKVM.Tools.Core/Diagnostics/JsonDiagnosticFormatter.cs

@@ -28,7 +28,7 @@ public JsonDiagnosticFormatter(JsonDiagnosticFormatterOptions options) :
         protected override void WriteImpl(in DiagnosticEvent @event, IDiagnosticChannel channel)
         {
             var encoding = channel.Encoding ?? Encoding.UTF8;
-            using var buffer = MemoryPool<byte>.Shared.Rent(8192);
+            using var buffer = MemoryPool<byte>.Shared.Rent(65535);
             var writer = new MemoryBufferWriter<byte>(buffer.Memory);
             JsonDiagnosticFormat.Write(@event.Diagnostic.Id, @event.Diagnostic.Level, @event.Diagnostic.Message, @event.Args, @event.Exception, @event.Location, ref writer, encoding);
             WriteLine(writer, encoding);

src/IKVM.Tools.Core/Diagnostics/TextDiagnosticFormatter.cs

@@ -28,7 +28,7 @@ public TextDiagnosticFormatter(TextDiagnosticFormatterOptions options) :
         protected override void WriteImpl(in DiagnosticEvent @event, IDiagnosticChannel channel)
         {
             var encoding = channel.Encoding ?? Encoding.UTF8;
-            using var buffer = MemoryPool<byte>.Shared.Rent(8192);
+            using var buffer = MemoryPool<byte>.Shared.Rent(65535);
             var writer = new MemoryBufferWriter<byte>(buffer.Memory);
             TextDiagnosticFormat.Write(@event.Diagnostic.Id, @event.Diagnostic.Level, @event.Diagnostic.Message, @event.Args, @event.Exception, @event.Location, ref writer, encoding);
             WriteLine(writer, encoding);