Skip to content

Commit 082c4e3

Browse files
authored
fixing update dataset version (#1105)
1 parent b57275a commit 082c4e3

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

src/datachain/data_storage/metastore.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -674,7 +674,7 @@ def update_dataset_version(
674674
dv = self._datasets_versions
675675
self.db.execute(
676676
self._datasets_versions_update()
677-
.where(dv.c.dataset_id == dataset.id and dv.c.version == version)
677+
.where(dv.c.dataset_id == dataset.id, dv.c.version == version)
678678
.values(values),
679679
conn=conn,
680680
) # type: ignore [attr-defined]

tests/unit/lib/test_datachain.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3270,3 +3270,13 @@ def test_wrong_semver_format(test_session):
32703270
"Invalid version. It should be in format: <major>.<minor>.<patch> where"
32713271
" each version part is positive integer"
32723272
)
3273+
3274+
3275+
def test_semver_preview_ok(test_session):
3276+
ds_name = "numbers"
3277+
dc.read_values(num=[1, 2], session=test_session).save(ds_name)
3278+
dc.read_values(num=[3, 4], session=test_session).save(ds_name)
3279+
3280+
dataset = test_session.catalog.get_dataset(ds_name)
3281+
assert sorted([p["num"] for p in dataset.get_version("1.0.0").preview]) == [1, 2]
3282+
assert sorted([p["num"] for p in dataset.get_version("1.0.1").preview]) == [3, 4]

0 commit comments

Comments
 (0)