Skip to content

Commit 586abbf

Browse files
authored
pin torchcodec version for now (#1408)
1 parent bf78a4e commit 586abbf

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ jobs:
110110

111111
- name: Install FFmpeg on Windows
112112
if: runner.os == 'Windows'
113-
run: choco install ffmpeg
113+
run: choco install ffmpeg --version 7.0
114114

115115
- name: Install FFmpeg on macOS
116116
if: runner.os == 'macOS'

pyproject.toml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,8 @@ hf = [
9191
# Until datasets solve the issue, run test_hf_audio test to see if this can be removed
9292
# https://github.com/meta-pytorch/torchcodec/issues/912
9393
# https://github.com/huggingface/transformers/pull/41610
94-
"torch<2.9.0"
94+
"torch<2.9.0",
95+
"torchcodec<0.8.0 ; (sys_platform == 'linux' or sys_platform == 'darwin')"
9596
]
9697
video = [
9798
"ffmpeg-python",
@@ -139,6 +140,8 @@ examples = [
139140
"open_clip_torch",
140141
"openai",
141142
# Transformers still require it
143+
# Remove this after HF tests and example work w/o these restrictions,
144+
# make them >= probably
142145
"torchaudio<2.9.0"
143146
]
144147

tests/func/test_hf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def require_torchcodec(test_case):
2727
"""
2828
if not importlib.util.find_spec("torchcodec"):
2929
test_case = pytest.mark.skip(
30-
"test requires torchcoded, not available on Windows yet"
30+
"test requires torchcodec, not available on Windows yet"
3131
)(test_case)
3232
return test_case
3333

0 commit comments

Comments
 (0)