refactor(referencefs): override _open only for fsspec<2025.2.0
#884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fsspec < 2025.2.0 Following changes from fsspec/filesystem_spec#1778.
Deploying datachain-documentation with
|
| Latest commit: |
8e36956
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7e13d720.datachain-documentation.pages.dev |
| Branch Preview URL: | https://fsspec-2025-2-0.datachain-documentation.pages.dev |
skshetry
changed the title
ReferenceFileSystem._open for fsspec<2025.2.0_open only for fsspec<2025.2.0
skshetry
changed the title
_open only for fsspec<2025.2.0_open only for fsspec<2025.2.0
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #884 +/- ##
==========================================
- Coverage 87.65% 87.64% -0.02%
==========================================
Files 128 129 +1
Lines 11457 11463 +6
Branches 1544 1545 +1
==========================================
+ Hits 10043 10047 +4
- Misses 1026 1027 +1
- Partials 388 389 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
amritghimire
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes from fsspec/filesystem_spec#1778.