Skip to content

Commit 4a1a360

Browse files
authored
Return py 39 to tests (#479)
Was removed by mistake, some complaints from mypy regarding code used in fixtures.
1 parent 3595e01 commit 4a1a360

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

.github/workflows/check-test-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
fail-fast: false
2727
matrix:
2828
os: [ubuntu-latest, macos-latest, windows-latest]
29-
python: ["3.10", "3.11", "3.12", "3.13"]
29+
python: ["3.9", "3.10", "3.11", "3.12", "3.13"]
3030

3131
steps:
3232
- uses: actions/checkout@v5

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ keywords = ["git", "repo", "repository", "artifact", "registry", "developer-tool
1212
classifiers = [
1313
"Development Status :: 2 - Pre-Alpha",
1414
"Programming Language :: Python :: 3",
15+
"Programming Language :: Python :: 3.9",
1516
"Programming Language :: Python :: 3.10",
1617
"Programming Language :: Python :: 3.11",
1718
"Programming Language :: Python :: 3.12",

tests/conftest.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# pylint: disable=redefined-outer-name
2+
import inspect
23
import os
34
import sys
45
from time import sleep
@@ -18,7 +19,13 @@
1819

1920
class Runner:
2021
def __init__(self):
21-
self._runner = CliRunner()
22+
# Older versions of CliRunner need this
23+
# Can we removed when we drop Py 3.9 support
24+
init_sig = inspect.signature(CliRunner.__init__)
25+
if "mix_stderr" in init_sig.parameters:
26+
self._runner = CliRunner(mix_stderr=False) # pylint: disable=unexpected-keyword-arg
27+
else:
28+
self._runner = CliRunner()
2229

2330
def invoke(self, *args, **kwargs) -> Result:
2431
return self._runner.invoke(app, *args, **kwargs)

0 commit comments

Comments
 (0)