Skip to content

Commit 1a2d5c2

Browse files
authored
Use vscode tree.tableColumnsBorder to add contrast in light themes (#1803)
* Use vscode tree.tableColumnsBorder to add contrast in light themes * Add variable to storybook test-vscode-styles.scss * Remove border bottom for leaf headers
1 parent 1d572b5 commit 1a2d5c2

File tree

4 files changed

+9
-2
lines changed

4 files changed

+9
-2
lines changed

webview/src/experiments/components/table/TableHeader.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ const TableHeaderCell: React.FC<{
104104
[styles.paramHeaderCell]: column.group === ColumnType.PARAMS,
105105
[styles.metricHeaderCell]: column.group === ColumnType.METRICS,
106106
[styles.firstLevelHeader]: isFirstLevelHeader(column.id),
107+
[styles.leafHeader]: column.headers === undefined,
107108
...sortingClasses()
108109
}
109110
)

webview/src/experiments/components/table/styles.module.scss

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -370,15 +370,19 @@ $workspace-row-edge-margin: $edge-padding - $cell-padding;
370370

371371
.placeholderHeaderCell {
372372
background-color: $header-bg-color;
373-
border-right: 2px solid $bg-color;
373+
border-right: 2px solid $header-border-color;
374374
}
375375

376376
.headerCell {
377377
@extend .placeholderHeaderCell;
378378
color: $header-fg-color;
379379
text-align: center;
380-
border-bottom: 2px solid $bg-color;
380+
border-bottom: 2px solid $header-border-color;
381381
padding: 0.31rem $cell-padding;
382+
383+
&.leafHeader {
384+
border-bottom: none;
385+
}
382386
}
383387

384388
.sortingHeaderCellAsc {

webview/src/shared/variables.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ $row-bg-color: $bg-color;
1212
$header-fg-color: $fg-color;
1313
$row-bg-alt-color: var(--vscode-sideBar-background);
1414
$header-bg-color: var(--vscode-dropdown-background);
15+
$header-border-color: var(--vscode-tree-tableColumnsBorder);
1516
$meta-cell-color: var(--vscode-descriptionForeground);
1617

1718
$hover-background-color: var(--vscode-list-hoverBackground);

webview/src/stories/test-vscode-styles.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ html {
102102
--vscode-listFilterWidget-noMatchesOutline: #be1100;
103103
--vscode-list-filterMatchBackground: rgba(234, 92, 0, 0.33);
104104
--vscode-tree-indentGuidesStroke: #585858;
105+
--vscode-tree-tableColumnsBorder: #1e1e1e;
105106
--vscode-list-deemphasizedForeground: #8c8c8c;
106107
--vscode-menu-foreground: #cccccc;
107108
--vscode-menu-background: #252526;

0 commit comments

Comments
 (0)