Show a screen when there is no data in the project (#2927)

* Show a screen when there is no data in the project

* Change title of get started webview

* Add content to the no data screen

* Clean yarn.lock

* Rebuild yarn.lock

* Retry cleaning yarn.lock

* Revert webview-ui-toolkit back to 1.0.0

* Completely revert yarn.lock file and reinstall

* Revert yarn.lock with right file

* Fix test

* Apply review comments

Author: sroy3

extension/package.json

@@ -1351,12 +1351,12 @@
       {
         "view": "dvc.views.webviews",
         "contents": "[Show Experiments](command:dvc.showExperiments)\n[Show Plots](command:dvc.showPlots)\n[Show Experiments and Plots](command:dvc.showExperimentsAndPlots)",
-        "when": "dvc.commands.available && dvc.project.available"
+        "when": "dvc.commands.available && dvc.project.available && dvc.project.hasData"
       },
       {
         "view": "dvc.views.webviews",
         "contents": "[Show Experiments](command:dvc.showGetStartedWebview)\n[Show Plots](command:dvc.showGetStartedWebview)\n[Show Experiments and Plots](command:dvc.showGetStartedWebview)",
-        "when": "!dvc.commands.available || !dvc.project.available"
+        "when": "!dvc.commands.available || !dvc.project.available || !dvc.project.hasData"
       },
       {
         "view": "dvc.views.welcome",

extension/src/experiments/index.ts

@@ -41,6 +41,7 @@ import { createTypedAccumulator } from '../util/object'
 import { pickPaths } from '../path/selection/quickPick'
 import { Toast } from '../vscode/toast'
 import { ConfigKey } from '../vscode/config'
+import { setContextValue } from '../vscode/context'
 import { checkSignalFile } from '../fileSystem'
 import { DVCLIVE_ONLY_RUNNING_SIGNAL_FILE } from '../cli/dvc/constants'
 
@@ -495,6 +496,10 @@ export class Experiments extends BaseRepository<TableData> {
     return this.columns.getFirstThreeColumnOrder()
   }
 
+  public getHasData() {
+    return this.columns.hasNonDefaultColumns()
+  }
+
   private setupInitialData() {
     const waitForInitialData = this.dispose.track(
       this.onDidChangeExperiments(() => {
@@ -517,6 +522,8 @@ export class Experiments extends BaseRepository<TableData> {
 
   private notifyColumnsChanged() {
     this.columnsChanged.fire()
+    const hasData = this.getHasData()
+    setContextValue('dvc.project.hasData', hasData)
     return this.webviewMessages.sendWebviewMessage()
   }
 

extension/src/experiments/workspace.ts

@@ -329,6 +329,12 @@ export class WorkspaceExperiments extends BaseWorkspaceWebviews<
     )
   }
 
+  public getHasData() {
+    return Object.values(this.repositories).some(repository =>
+      repository.getHasData()
+    )
+  }
+
   private async pickExpThenRun(
     commandId: CommandId,
     pickFunc: (

extension/src/extension.ts

@@ -162,7 +162,8 @@ export class Extension extends Disposable implements IExtension {
         () => this.initProject(),
         () => this.showExperiments(this.dvcRoots[0]),
         () => this.getAvailable(),
-        () => this.hasRoots()
+        () => this.hasRoots(),
+        () => this.experiments.getHasData()
       )
     )
 

extension/src/getStarted/index.ts

@@ -15,14 +15,16 @@ export class GetStarted extends BaseRepository<TGetStartedData> {
   private showExperiments: () => void
   private getCliAccessible: () => boolean
   private getHasRoots: () => boolean
+  private getHasData: () => boolean
 
   constructor(
     dvcRoot: string,
     webviewIcon: Resource,
     initProject: () => void,
     showExperiments: () => void,
     getCliAccessible: () => boolean,
-    getHasRoots: () => boolean
+    getHasRoots: () => boolean,
+    getHasData: () => boolean
   ) {
     super(dvcRoot, webviewIcon)
 
@@ -35,6 +37,7 @@ export class GetStarted extends BaseRepository<TGetStartedData> {
     this.getHasRoots = getHasRoots
     this.initProject = initProject
     this.showExperiments = showExperiments
+    this.getHasData = getHasData
   }
 
   public sendInitialWebviewData() {
@@ -44,7 +47,8 @@ export class GetStarted extends BaseRepository<TGetStartedData> {
   public sendDataToWebview() {
     this.webviewMessages.sendWebviewMessage(
       this.getCliAccessible(),
-      this.getHasRoots()
+      this.getHasRoots(),
+      this.getHasData()
     )
   }
 

extension/src/getStarted/webview/contract.ts

@@ -1,4 +1,5 @@
 export type GetStartedData = {
   cliAccessible: boolean
   projectInitialized: boolean
+  hasData: boolean
 }

extension/src/getStarted/webview/messages.ts

@@ -23,10 +23,12 @@ export class WebviewMessages {
 
   public sendWebviewMessage(
     cliAccessible: boolean,
-    projectInitialized: boolean
+    projectInitialized: boolean,
+    hasData: boolean
   ) {
     this.getWebview()?.show({
       cliAccessible,
+      hasData,
       projectInitialized
     })
   }

extension/src/test/suite/experiments/index.test.ts

@@ -1583,7 +1583,7 @@ suite('Experiments Test Suite', () => {
       ).to.be.false
     })
 
-    it('should not set a context value when a non-params file is open and the extension starts', async () => {
+    it('should only set the context value for hasData when a non-params file is open and the extension starts', async () => {
       const nonParamsFile = Uri.file(join(dvcDemoPath, '.gitignore'))
       await window.showTextDocument(nonParamsFile)
 
@@ -1592,7 +1592,10 @@ suite('Experiments Test Suite', () => {
       const { experiments } = buildExperiments(disposable)
       await experiments.isReady()
 
-      expect(setContextValueSpy).not.to.be.called
+      expect(setContextValueSpy).to.be.calledOnceWith(
+        'dvc.project.hasData',
+        true
+      )
     })
   })
 

extension/src/test/suite/getStarted/util.ts

@@ -16,6 +16,7 @@ export const buildGetStarted = (disposer: Disposer, dvInstalled = false) => {
       mockInitializeProject,
       mockOpenExperiments,
       () => dvInstalled,
+      () => false,
       () => false
     )
   )

extension/src/webview/constants.ts

@@ -63,7 +63,7 @@ export const WebviewDetails: {
       focusChangedEvent: EventName.VIEWS_GET_STARTED_FOCUS_CHANGED
     },
     scripts: [react, getStarted],
-    title: 'DVC is not initialized',
+    title: 'Setup',
     viewKey: ViewKey.GET_STARTED
   }
 } as const