Use regex to handle detached HEAD branch name in other languages (#4137)

Author: mattseddon

extension/src/util/stdout.test.ts

@@ -1,4 +1,4 @@
-import { trimAndSplit } from './stdout'
+import { cleanUpBranchName, trimAndSplit } from './stdout'
 
 describe('trimAndSplit', () => {
   it('should return an empty array given an empty string', () => {
@@ -13,3 +13,15 @@ describe('trimAndSplit', () => {
     expect(trimAndSplit('a\nb\nc\n')).toStrictEqual(['a', 'b', 'c'])
   })
 })
+
+describe('cleanUpBranchName', () => {
+  it('should clean up a detached head message in English', () => {
+    const branchName = '(HEAD detached at 786cfcd)'
+    expect(cleanUpBranchName(branchName)).toStrictEqual('786cfcd')
+  })
+
+  it('should clean up a detached head message in Spanish', () => {
+    const branchName = '(HEAD desacoplado en 786cfcd)'
+    expect(cleanUpBranchName(branchName)).toStrictEqual('786cfcd')
+  })
+})

extension/src/util/stdout.ts

@@ -6,4 +6,7 @@ export const trimAndSplit = (stdout: string): string[] =>
     .filter(Boolean)
 
 export const cleanUpBranchName = (branch: string) =>
-  branch.replace('* ', '').replace('(HEAD detached at ', '').replace(')', '')
+  branch
+    .replace('* ', '')
+    .replace(/\(HEAD\s\w+\s\w+\s/, '')
+    .replace(')', '')