chore(deps): update dependency eslint-plugin-unicorn to v45 (#2839)

renovate[bot] · mattseddon · web-flow · commit 469ba55f8939 · 2022-11-28T17:21:15.000Z
Co-authored-by: Matt Seddon &lt;mattseddon@hotmail.com&gt;
diff --git a/extension/src/experiments/columns/collect/util.ts b/extension/src/experiments/columns/collect/util.ts
@@ -76,16 +76,16 @@ const mergeParentColumnByPath = (
   parentPath: string,
   label: string
 ) => {
-  if (!acc[path]) {
+  if (acc[path]) {
+    acc[path].hasChildren = true
+  } else {
     acc[path] = {
       hasChildren: true,
       label,
       parentPath,
       path,
       type
     }
-  } else {
-    acc[path].hasChildren = true
   }
 }
 
diff --git a/extension/src/experiments/model/quickPicks.ts b/extension/src/experiments/model/quickPicks.ts
@@ -33,7 +33,7 @@ const getItem = (experiment: Experiment, firstThreeColumnOrder: string[]) => ({
         15
       )
 
-      return value !== null ? `${truncatedKey}:${value}` : ''
+      return value === null ? '' : `${truncatedKey}:${value}`
     })
     .filter(Boolean)
     .join(', '),
diff --git a/extension/src/experiments/model/tree.ts b/extension/src/experiments/model/tree.ts
@@ -355,7 +355,7 @@ export class ExperimentsTree
           path.slice(type.length + 1) || path,
           30
         )
-        return value !== null ? `| ${truncatedKey} | ${value} |\n` : ''
+        return value === null ? '' : `| ${truncatedKey} | ${value} |\n`
       })
       .join('')
 
diff --git a/extension/src/experiments/model/util.ts b/extension/src/experiments/model/util.ts
@@ -46,7 +46,7 @@ export const getDataFromColumnPath = (
   return {
     splitUpPath,
     value:
-      columnPath === 'Created' && typeof value === 'undefined'
+      columnPath === 'Created' && value === 'undefined'
         ? null
         : getStringifiedValue(value)
   }
diff --git a/package.json b/package.json
@@ -56,7 +56,7 @@
     "eslint-plugin-sonarjs": "0.16.0",
     "eslint-plugin-sort-keys-fix": "1.1.2",
     "eslint-plugin-testing-library": "5.9.1",
-    "eslint-plugin-unicorn": "44.0.2",
+    "eslint-plugin-unicorn": "45.0.0",
     "husky": "8.0.2",
     "jest": "29.3.1",
     "lint-staged": "13.0.3",
diff --git a/webview/src/plots/components/GetStarted.tsx b/webview/src/plots/components/GetStarted.tsx
@@ -29,7 +29,7 @@ export const AddPlots: React.FC<AddPlotsProps> = ({
       )}
       {!hasSelectedRevisions && (
         <StartButton
-          appearance={!hasSelectedPlots ? 'secondary' : 'primary'}
+          appearance={hasSelectedPlots ? 'primary' : 'secondary'}
           isNested={!hasSelectedPlots}
           onClick={() =>
             sendMessage({
diff --git a/webview/src/plots/components/templatePlots/util.ts b/webview/src/plots/components/templatePlots/util.ts
@@ -18,7 +18,7 @@ const add = (
 ) => {
   const entries = [...section.entries]
   entries.splice(
-    position !== undefined ? position : entries.length - 1,
+    position === undefined ? entries.length - 1 : position,
     0,
     entry
   )
diff --git a/webview/src/stories/Plots.stories.tsx b/webview/src/stories/Plots.stories.tsx
@@ -241,12 +241,10 @@ SmoothTemplate.args = {
       ...templatePlotsFixture,
       plots: [
         {
-          entries: [
-            ...templatePlotsFixture.plots[0].entries.map(plot => ({
-              ...plot,
-              content: { ...smoothTemplatePlotContent }
-            }))
-          ],
+          entries: templatePlotsFixture.plots[0].entries.map(plot => ({
+            ...plot,
+            content: { ...smoothTemplatePlotContent }
+          })),
           group: TemplatePlotGroup.SINGLE_VIEW
         } as unknown as TemplatePlotSection
       ]
diff --git a/webview/src/test/dragDrop.ts b/webview/src/test/dragDrop.ts
@@ -60,7 +60,9 @@ export const dragEnter = (
   draggedOver = idToNode(draggedOverId)
 
   act(() => {
-    if (direction !== DragEnterDirection.AUTO) {
+    if (direction === DragEnterDirection.AUTO) {
+      draggedOver?.dispatchEvent(createBubbledEvent('dragover'))
+    } else {
       const left = 100
       const right = left + 100
       const top = 100
@@ -82,8 +84,6 @@ export const dragEnter = (
 
       draggedOver?.dispatchEvent(dragOverEvent)
       jest.advanceTimersByTime(1)
-    } else {
-      draggedOver?.dispatchEvent(createBubbledEvent('dragover'))
     }
   })
 
diff --git a/yarn.lock b/yarn.lock
@@ -6849,10 +6849,10 @@ ci-info@^3.2.0:
   resolved "https://registry.yarnpkg.com/ci-info/-/ci-info-3.3.0.tgz#b4ed1fb6818dea4803a55c623041f9165d2066b2"
   integrity sha512-riT/3vI5YpVH6/qomlDnJow6TBee2PBKSEpx3O32EGPYbWGIRsIlGRms3Sm74wYE1JMo8RnO04Hb12+v1J5ICw==
 
-ci-info@^3.4.0:
-  version "3.5.0"
-  resolved "https://registry.yarnpkg.com/ci-info/-/ci-info-3.5.0.tgz#bfac2a29263de4c829d806b1ab478e35091e171f"
-  integrity sha512-yH4RezKOGlOhxkmhbeNuC4eYZKAUsEaGtBuBzDDP1eFUKiccDWzBABxBfOx31IDwDIXMTxWuwAxUGModvkbuVw==
+ci-info@^3.6.1:
+  version "3.7.0"
+  resolved "https://registry.yarnpkg.com/ci-info/-/ci-info-3.7.0.tgz#6d01b3696c59915b6ce057e4aa4adfc2fa25f5ef"
+  integrity sha512-2CpRNYmImPx+RXKLq6jko/L07phmS9I02TyqkcNU20GCF/GgaWvc58hPtjxDX8lPpkdwc9sNh72V9k00S7ezog==
 
 cipher-base@^1.0.0, cipher-base@^1.0.1, cipher-base@^1.0.3:
   version "1.0.4"
@@ -8965,24 +8965,26 @@ eslint-plugin-testing-library@5.9.1:
   dependencies:
     "@typescript-eslint/utils" "^5.13.0"
 
-eslint-plugin-unicorn@44.0.2:
-  version "44.0.2"
-  resolved "https://registry.yarnpkg.com/eslint-plugin-unicorn/-/eslint-plugin-unicorn-44.0.2.tgz#6324a001c0a5e2ac00fb51b30db27d14c6c36ab3"
-  integrity sha512-GLIDX1wmeEqpGaKcnMcqRvMVsoabeF0Ton0EX4Th5u6Kmf7RM9WBl705AXFEsns56ESkEs0uyelLuUTvz9Tr0w==
+eslint-plugin-unicorn@45.0.0:
+  version "45.0.0"
+  resolved "https://registry.yarnpkg.com/eslint-plugin-unicorn/-/eslint-plugin-unicorn-45.0.0.tgz#a6650ff3000dc1a87cc2f6ac3a11edcde61712e2"
+  integrity sha512-iP8cMRxXKHonKioOhnCoCcqVhoqhAp6rB+nsoLjXFDxTHz3btWMAp8xwzjHA0B1K6YV/U/Yvqn1bUXZt8sJPuQ==
   dependencies:
     "@babel/helper-validator-identifier" "^7.19.1"
-    ci-info "^3.4.0"
+    ci-info "^3.6.1"
     clean-regexp "^1.0.0"
     eslint-utils "^3.0.0"
     esquery "^1.4.0"
     indent-string "^4.0.0"
     is-builtin-module "^3.2.0"
+    jsesc "3.0.2"
     lodash "^4.17.21"
     pluralize "^8.0.0"
     read-pkg-up "^7.0.1"
     regexp-tree "^0.1.24"
+    regjsparser "0.9.1"
     safe-regex "^2.1.1"
-    semver "^7.3.7"
+    semver "^7.3.8"
     strip-indent "^3.0.0"
 
 eslint-scope@5.1.1, eslint-scope@^5.1.1:
@@ -12402,6 +12404,11 @@ jsdom@^20.0.0:
     ws "^8.8.0"
     xml-name-validator "^4.0.0"
 
+jsesc@3.0.2:
+  version "3.0.2"
+  resolved "https://registry.yarnpkg.com/jsesc/-/jsesc-3.0.2.tgz#bb8b09a6597ba426425f2e4a07245c3d00b9343e"
+  integrity sha512-xKqzzWXDttJuOcawBt4KnKHHIf5oQ/Cxax+0PWFG+DFDgHNAdi+TXECADI+RYiFUMmx8792xsMbbgXj4CwnP4g==
+
 jsesc@^2.5.1:
   version "2.5.2"
   resolved "https://registry.yarnpkg.com/jsesc/-/jsesc-2.5.2.tgz#80564d2e483dacf6e8ef209650a67df3f0c283a4"
@@ -15580,6 +15587,13 @@ regjsgen@^0.6.0:
   resolved "https://registry.yarnpkg.com/regjsgen/-/regjsgen-0.6.0.tgz#83414c5354afd7d6627b16af5f10f41c4e71808d"
   integrity sha512-ozE883Uigtqj3bx7OhL1KNbCzGyW2NQZPl6Hs09WTvCuZD5sTI4JY58bkbQWa/Y9hxIsvJ3M8Nbf7j54IqeZbA==
 
+regjsparser@0.9.1:
+  version "0.9.1"
+  resolved "https://registry.yarnpkg.com/regjsparser/-/regjsparser-0.9.1.tgz#272d05aa10c7c1f67095b1ff0addae8442fc5709"
+  integrity sha512-dQUtn90WanSNl+7mQKcXAgZxvUe7Z0SqXlgzv0za4LwiUhyzBC58yQO3liFoUgu8GiJVInAhJjkj1N0EtQ5nkQ==
+  dependencies:
+    jsesc "~0.5.0"
+
 regjsparser@^0.8.2:
   version "0.8.4"
   resolved "https://registry.yarnpkg.com/regjsparser/-/regjsparser-0.8.4.tgz#8a14285ffcc5de78c5b95d62bbf413b6bc132d5f"

Original file line number	Diff line number	Diff line change
`@@ -76,16 +76,16 @@ const mergeParentColumnByPath = (`
`76`	`76`	`parentPath: string,`
`77`	`77`	`label: string`
`78`	`78`	`) => {`
`79`		`- if (!acc[path]) {`
	`79`	`+ if (acc[path]) {`
	`80`	`+ acc[path].hasChildren = true`
	`81`	`+ } else {`
`80`	`82`	`acc[path] = {`
`81`	`83`	`hasChildren: true,`
`82`	`84`	`label,`
`83`	`85`	`parentPath,`
`84`	`86`	`path,`
`85`	`87`	`type`
`86`	`88`	`}`
`87`		`- } else {`
`88`		`- acc[path].hasChildren = true`
`89`	`89`	`}`
`90`	`90`	`}`
`91`	`91`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ const getItem = (experiment: Experiment, firstThreeColumnOrder: string[]) => ({`
`33`	`33`	`15`
`34`	`34`	`)`
`35`	`35`
`36`		- return value !== null ? `${truncatedKey}:${value}` : ''
	`36`	+ return value === null ? '' : `${truncatedKey}:${value}`
`37`	`37`	`})`
`38`	`38`	`.filter(Boolean)`
`39`	`39`	`.join(', '),`
Original file line number	Diff line number	Diff line change
`@@ -355,7 +355,7 @@ export class ExperimentsTree`
`355`	`355`	`path.slice(type.length + 1) \|\| path,`
`356`	`356`	`30`
`357`	`357`	`)`
`358`		- return value !== null ? `\| ${truncatedKey} \| ${value} \|\n` : ''
	`358`	+ return value === null ? '' : `\| ${truncatedKey} \| ${value} \|\n`
`359`	`359`	`})`
`360`	`360`	`.join('')`
`361`	`361`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ export const getDataFromColumnPath = (`
`46`	`46`	`return {`
`47`	`47`	`splitUpPath,`
`48`	`48`	`value:`
`49`		`- columnPath === 'Created' && typeof value === 'undefined'`
	`49`	`+ columnPath === 'Created' && value === 'undefined'`
`50`	`50`	`? null`
`51`	`51`	`: getStringifiedValue(value)`
`52`	`52`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ const add = (`
`18`	`18`	`) => {`
`19`	`19`	`const entries = [...section.entries]`
`20`	`20`	`entries.splice(`
`21`		`- position !== undefined ? position : entries.length - 1,`
	`21`	`+ position === undefined ? entries.length - 1 : position,`
`22`	`22`	`0,`
`23`	`23`	`entry`
`24`	`24`	`)`