Skip to content

Commit 54c2e6e

Browse files
committed
Add telemetry call when hiding a column in the table view
1 parent 82a5fb8 commit 54c2e6e

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

extension/src/experiments/index.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,15 @@ export class Experiments extends BaseRepository<TableData> {
350350
}
351351
}
352352

353+
private hideTableColumn(path: string) {
354+
this.toggleColumnStatus(path)
355+
sendTelemetryEvent(
356+
EventName.VIEWS_EXPERIMENTS_TABLE_HIDE_COLUMN,
357+
{ path },
358+
undefined
359+
)
360+
}
361+
353362
private setupInitialData() {
354363
const waitForInitialData = this.dispose.track(
355364
this.onDidChangeExperiments(() => {
@@ -408,7 +417,7 @@ export class Experiments extends BaseRepository<TableData> {
408417
case MessageFromWebviewType.TOGGLE_EXPERIMENT:
409418
return this.setExperimentStatus(message.payload)
410419
case MessageFromWebviewType.HIDE_EXPERIMENTS_TABLE_COLUMN:
411-
return this.toggleColumnStatus(message.payload)
420+
return this.hideTableColumn(message.payload)
412421
case MessageFromWebviewType.SORT_COLUMN:
413422
return this.addColumnSort(message.payload)
414423
case MessageFromWebviewType.REMOVE_COLUMN_SORT:

extension/src/telemetry/constants.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ export const EventName = Object.assign(
3636
'views.experimentTable.toggleStatus',
3737
VIEWS_EXPERIMENTS_TABLE_FOCUS_CHANGED:
3838
'views.experimentsTable.focusChanged',
39+
VIEWS_EXPERIMENTS_TABLE_HIDE_COLUMN: 'views.experimentsTable.columnHidden',
3940
VIEWS_EXPERIMENTS_TABLE_REMOVE_COLUMN_SORT:
4041
'views.experimentsTable.columnSortRemoved',
4142
VIEWS_EXPERIMENTS_TABLE_RESIZE_COLUMN:
@@ -187,6 +188,9 @@ export interface IEventNamePropertyMapping {
187188
}
188189
[EventName.VIEWS_EXPERIMENTS_TABLE_CREATED]: undefined
189190
[EventName.VIEWS_EXPERIMENTS_TABLE_FOCUS_CHANGED]: WebviewFocusChangedProperties
191+
[EventName.VIEWS_EXPERIMENTS_TABLE_HIDE_COLUMN]: {
192+
path: string
193+
}
190194

191195
[EventName.VIEWS_PLOTS_CLOSED]: undefined
192196
[EventName.VIEWS_PLOTS_CREATED]: undefined

0 commit comments

Comments
 (0)