Skip to content

Commit 658b1a9

Browse files
authored
Fix integration test suite after hook (#2628)
1 parent a501e6b commit 658b1a9

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

extension/src/experiments/columns/collect/util.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export const limitAncestorDepth = (
3434
} => {
3535
const [path, ...rest] = ancestors
3636
const collectedLimit = Number(
37-
getConfigValue(ConfigKey.EXP_TABLE_HEAD_MAX_DEPTH, limit)
37+
getConfigValue(ConfigKey.EXP_TABLE_HEAD_MAX_HEIGHT, limit)
3838
)
3939

4040
switch (collectedLimit) {

extension/src/experiments/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ export class Experiments extends BaseRepository<TableData> {
132132

133133
this.dispose.track(
134134
workspace.onDidChangeConfiguration((event: ConfigurationChangeEvent) => {
135-
if (event.affectsConfiguration(ConfigKey.EXP_TABLE_HEAD_MAX_DEPTH)) {
135+
if (event.affectsConfiguration(ConfigKey.EXP_TABLE_HEAD_MAX_HEIGHT)) {
136136
this.cliData.update()
137137
}
138138
})

extension/src/experiments/webview/messages.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ export class WebviewMessages {
186186
return
187187
}
188188

189-
setConfigValue(ConfigKey.EXP_TABLE_HEAD_MAX_DEPTH, Number(newValue))
189+
setConfigValue(ConfigKey.EXP_TABLE_HEAD_MAX_HEIGHT, Number(newValue))
190190
sendTelemetryEvent(
191191
EventName.VIEWS_EXPERIMENTS_TABLE_SET_MAX_HEADER_HEIGHT,
192192
undefined,

extension/src/test/suite/experiments/index.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -173,11 +173,11 @@ suite('Experiments Test Suite', () => {
173173
})
174174

175175
describe('handleMessageFromWebview', () => {
176-
after(() => {
176+
after(() =>
177177
workspace
178-
.getConfiguration(ConfigKey.EXP_TABLE_HEAD_MAX_DEPTH)
179-
.update('', undefined, false)
180-
})
178+
.getConfiguration()
179+
.update(ConfigKey.EXP_TABLE_HEAD_MAX_HEIGHT, undefined, false)
180+
)
181181

182182
const setupExperimentsAndMockCommands = () => {
183183
const {
@@ -891,7 +891,7 @@ suite('Experiments Test Suite', () => {
891891
const { experiments } = buildExperiments(disposable, expShowFixture)
892892
const inputEvent = getInputBoxEvent('0')
893893
const tableMaxDepthChanged = configurationChangeEvent(
894-
ConfigKey.EXP_TABLE_HEAD_MAX_DEPTH,
894+
ConfigKey.EXP_TABLE_HEAD_MAX_HEIGHT,
895895
disposable
896896
)
897897

@@ -907,7 +907,7 @@ suite('Experiments Test Suite', () => {
907907
await tableMaxDepthChanged
908908

909909
expect(
910-
workspace.getConfiguration().get(ConfigKey.EXP_TABLE_HEAD_MAX_DEPTH)
910+
workspace.getConfiguration().get(ConfigKey.EXP_TABLE_HEAD_MAX_HEIGHT)
911911
).to.equal(0)
912912
expect(mockSendTelemetryEvent).to.be.called
913913
expect(

extension/src/vscode/config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ export enum ConfigKey {
55
DO_NOT_SHOW_CLI_UNAVAILABLE = 'dvc.doNotShowCliUnavailable',
66
DO_NOT_SHOW_WALKTHROUGH_AFTER_INSTALL = 'dvc.doNotShowWalkthroughAfterInstall',
77
DO_NOT_SHOW_UNABLE_TO_FILTER = 'dvc.doNotShowUnableToFilter',
8-
EXP_TABLE_HEAD_MAX_DEPTH = 'dvc.experimentsTableHeadMaxHeight',
8+
EXP_TABLE_HEAD_MAX_HEIGHT = 'dvc.experimentsTableHeadMaxHeight',
99
DVC_PATH = 'dvc.dvcPath',
1010
PYTHON_PATH = 'dvc.pythonPath'
1111
}

0 commit comments

Comments
 (0)