Skip to content

Commit 73a424a

Browse files
authored
Direct user to setup when they cannot run an experiment (#3323)
1 parent 7acb1c7 commit 73a424a

File tree

3 files changed

+15
-3
lines changed

3 files changed

+15
-3
lines changed

extension/package.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1374,7 +1374,13 @@
13741374
"viewsWelcome": [
13751375
{
13761376
"view": "dvc.views.actions",
1377-
"contents": "[$(beaker) Show Experiments](command:dvc.showExperiments)\n[$(graph-scatter) Show Plots](command:dvc.showPlots)\n[$(play) Run Experiment](command:dvc.runExperiment)"
1377+
"contents": "[$(beaker) Show Experiments](command:dvc.showExperiments)\n[$(graph-scatter) Show Plots](command:dvc.showPlots)\n[$(play) Run Experiment](command:dvc.runExperiment)",
1378+
"when": "!dvc.experiment.checkpoints"
1379+
},
1380+
{
1381+
"view": "dvc.views.actions",
1382+
"contents": "[$(beaker) Show Experiments](command:dvc.showExperiments)\n[$(graph-scatter) Show Plots](command:dvc.showPlots)\n[$(play) Run Experiment](command:dvc.resetAndRunCheckpointExperiment)",
1383+
"when": "dvc.experiment.checkpoints"
13781384
},
13791385
{
13801386
"view": "dvc.views.studio",

extension/src/experiments/commands/register.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,9 @@ const registerExperimentRunCommands = (
289289
): void => {
290290
internalCommands.registerExternalCliCommand(
291291
RegisteredCliCommands.EXPERIMENT_RUN,
292-
() => experiments.getCwdThenRun(AvailableCommands.EXPERIMENT_RUN)
292+
showSetupOrExecuteCommand(setup, () =>
293+
experiments.getCwdThenRun(AvailableCommands.EXPERIMENT_RUN)
294+
)
293295
)
294296

295297
internalCommands.registerExternalCliCommand(
@@ -299,7 +301,9 @@ const registerExperimentRunCommands = (
299301

300302
internalCommands.registerExternalCliCommand(
301303
RegisteredCliCommands.EXPERIMENT_RESET_AND_RUN,
302-
() => experiments.getCwdThenRun(AvailableCommands.EXPERIMENT_RESET_AND_RUN)
304+
showSetupOrExecuteCommand(setup, () =>
305+
experiments.getCwdThenRun(AvailableCommands.EXPERIMENT_RESET_AND_RUN)
306+
)
303307
)
304308

305309
internalCommands.registerExternalCliCommand(

extension/src/test/suite/experiments/workspace.test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -411,6 +411,7 @@ suite('Workspace Experiments Test Suite', () => {
411411
DvcRunner.prototype,
412412
'runExperiment'
413413
).resolves(undefined)
414+
stub(Setup.prototype, 'shouldBeShown').returns(false)
414415

415416
stubWorkspaceExperimentsGetters(dvcDemoPath)
416417

@@ -446,6 +447,7 @@ suite('Workspace Experiments Test Suite', () => {
446447
DvcRunner.prototype,
447448
'runExperimentReset'
448449
).resolves(undefined)
450+
stub(Setup.prototype, 'shouldBeShown').returns(false)
449451

450452
stubWorkspaceExperimentsGetters(dvcDemoPath)
451453

0 commit comments

Comments
 (0)