Add import/no-unused-modules rule to eslint config (#3826)

Author: mattseddon

.eslintrc.js

@@ -69,6 +69,23 @@ module.exports = {
       rules: {
         'unicorn/filename-case': 'off'
       }
+    },
+    {
+      files: [
+        'src/extension.ts',
+        '**/*.stories.tsx',
+        '**/stories/util.ts',
+        '**/__mocks__/**',
+        'src/test/util/index.ts',
+        'src/test/e2e/**',
+        'src/test/suite/index.ts',
+        '**/*Slice.ts',
+        '**/store.ts',
+        '**/contract.ts'
+      ],
+      rules: {
+        'import/no-unused-modules': 'off'
+      }
     }
   ],
   plugins: [
@@ -104,6 +121,7 @@ module.exports = {
     'etc/no-commented-out-code': 'error',
     'etc/no-assign-mutated-array': 'error',
     'import/no-unresolved': 'off',
+    'import/no-unused-modules': [2, { unusedExports: true }],
     'import/order': [
       'error',
       {

extension/src/cli/dvc/discovery.ts

@@ -91,9 +91,7 @@ type CanRunCli = {
   version: string | undefined
 }
 
-export const isCliCompatible = (
-  cliCompatible: CliCompatible
-): boolean | undefined => {
+const isCliCompatible = (cliCompatible: CliCompatible): boolean | undefined => {
   if (cliCompatible === CliCompatible.NO_NOT_FOUND) {
     return
   }

extension/src/experiments/columns/collect/metricsAndParams.ts

@@ -73,7 +73,7 @@ const walkValueTree = (
   }
 }
 
-export const walkMetricsOrParamsFile = (
+const walkMetricsOrParamsFile = (
   acc: ColumnAccumulator,
   type: ColumnType,
   file: MetricsOrParams

extension/src/experiments/columns/paths.ts

@@ -12,9 +12,10 @@ const FILE_SPLIT_REGEX = new RegExp(
   `([^${FILE_SEPARATOR}]*)(?:${FILE_SEPARATOR}([^${FILE_SEPARATOR}]*))?(?:${FILE_SEPARATOR}(.*))?`
 )
 
-export const encodeColumn = (segment: string) =>
+const encodeColumn = (segment: string) =>
   segment.replace(ENCODE_METRIC_PARAM_REGEX, ENCODED_METRIC_PARAM_SEPARATOR)
-export const decodeColumn = (segment: string) =>
+
+const decodeColumn = (segment: string) =>
   segment.replace(DECODE_METRIC_PARAM_REGEX, METRIC_PARAM_SEPARATOR)
 
 export const appendColumnToPath = (...pathSegments: string[]) => {

extension/src/experiments/data/index.ts

@@ -1,4 +1,3 @@
-import { join } from 'path'
 import { collectFiles } from './collect'
 import {
   EXPERIMENTS_GIT_LOGS_REFS,
@@ -15,8 +14,6 @@ import { gitPath } from '../../cli/git/constants'
 import { getGitPath } from '../../fileSystem'
 import { ExperimentsModel } from '../model'
 
-export const QUEUED_EXPERIMENT_PATH = join(DOT_DVC, 'tmp', 'exps')
-
 export class ExperimentsData extends BaseData<ExpShowOutput> {
   private readonly experiments: ExperimentsModel
 

extension/src/experiments/model/index.ts

@@ -31,7 +31,7 @@ import { PersistenceKey } from '../../persistence/constants'
 import { sum } from '../../util/math'
 import { DEFAULT_NUM_OF_COMMITS_TO_SHOW } from '../../cli/dvc/constants'
 
-export type StarredExperiments = Record<string, boolean | undefined>
+type StarredExperiments = Record<string, boolean | undefined>
 
 export type SelectedExperimentWithColor = Experiment & {
   displayColor: Color

extension/src/experiments/model/status/colors.ts

@@ -1,4 +1,4 @@
-export const colorsList = [
+const colorsList = [
   '#945dd6',
   '#13adc7',
   '#f46837',
@@ -11,6 +11,3 @@ export const colorsList = [
 export type Color = (typeof colorsList)[number]
 
 export const copyOriginalColors = (): Color[] => [...colorsList]
-
-export const copyReverseOriginalColors = (): Color[] =>
-  [...colorsList].reverse()

extension/src/experiments/model/tree.ts

@@ -35,7 +35,7 @@ import { Experiment, ExperimentStatus, isRunning } from '../webview/contract'
 import { getMarkdownString } from '../../vscode/markdownString'
 import { truncateFromLeft } from '../../util/string'
 
-export type ExperimentAugmented = Experiment & {
+type ExperimentAugmented = Experiment & {
   hasChildren: boolean
   selected?: boolean
   starred: boolean

extension/src/experiments/workspace.ts

@@ -33,7 +33,7 @@ export enum scriptCommand {
   PYTHON = 'python'
 }
 
-export const getScriptCommand = (script: string) => {
+const getScriptCommand = (script: string) => {
   switch (getFileExtension(script)) {
     case '.py':
       return scriptCommand.PYTHON

extension/src/extension.ts

@@ -51,7 +51,7 @@ import { registerSetupCommands } from './setup/register'
 import { Status } from './status'
 import { registerPersistenceCommands } from './persistence/register'
 
-export class Extension extends Disposable {
+class Extension extends Disposable {
   protected readonly internalCommands: InternalCommands
 
   private readonly resourceLocator: ResourceLocator