Skip to content

Commit 8156d4c

Browse files
authored
Only show filtered counts if they are above 0 (#1907)
1 parent a983570 commit 8156d4c

File tree

2 files changed

+18
-16
lines changed

2 files changed

+18
-16
lines changed

webview/src/experiments/components/App.test.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -784,7 +784,7 @@ describe('App', () => {
784784

785785
const tooltip = screen.getByRole('tooltip')
786786

787-
expect(tooltip).toHaveTextContent('No filters applied')
787+
expect(tooltip.textContent).toBe('No filters applied')
788788

789789
const { columns } = tableDataFixture
790790
const firstFilterPath = columns[columns.length - 1].path
@@ -802,9 +802,7 @@ describe('App', () => {
802802
})
803803
)
804804
expect(filterIndicator).toHaveTextContent('1')
805-
expect(tooltip).toHaveTextContent('1 filter applied')
806-
expect(tooltip).toHaveTextContent('No experiments filtered')
807-
expect(tooltip).toHaveTextContent('No checkpoints filtered')
805+
expect(tooltip.textContent).toBe('1 filter applied')
808806
fireEvent(
809807
window,
810808
new MessageEvent('message', {

webview/src/experiments/components/table/Indicators.tsx

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -84,18 +84,22 @@ export const Indicators = ({
8484
<div>{formatCountMessage('filter', filtersCount)}</div>
8585
{filtersCount ? (
8686
<>
87-
<div>
88-
{formatFilteredCountMessage(
89-
'experiment',
90-
filteredCounts.experiments
91-
)}
92-
</div>
93-
<div>
94-
{formatFilteredCountMessage(
95-
'checkpoint',
96-
filteredCounts.checkpoints
97-
)}
98-
</div>
87+
{filteredCounts.experiments ? (
88+
<div>
89+
{formatFilteredCountMessage(
90+
'experiment',
91+
filteredCounts.experiments
92+
)}
93+
</div>
94+
) : null}
95+
{filteredCounts.checkpoints ? (
96+
<div>
97+
{formatFilteredCountMessage(
98+
'checkpoint',
99+
filteredCounts.checkpoints
100+
)}
101+
</div>
102+
) : null}
99103
</>
100104
) : null}
101105
</>

0 commit comments

Comments
 (0)