Skip to content

Commit 8539d34

Browse files
authored
Fix unit tests for non en-US timezones (#2748)
1 parent f0c5c4e commit 8539d34

File tree

2 files changed

+20
-9
lines changed

2 files changed

+20
-9
lines changed

extension/src/experiments/model/quickPick.test.ts

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import { MAX_SELECTED_EXPERIMENTS } from './status'
55
import { quickPickLimitedValues } from '../../vscode/quickPick'
66
import { Experiment } from '../webview/contract'
77
import { Title } from '../../vscode/title'
8+
import { formatDate } from '../../util/date'
89

910
jest.mock('../../vscode/quickPick')
1011

@@ -135,19 +136,25 @@ describe('pickExperiments', () => {
135136
[
136137
{
137138
description: '[exp-123]',
138-
detail: 'Created:Aug 19, 2022, split:0, data/data.xml:22a1a29',
139+
detail: `Created:${formatDate(
140+
mockedExperiments[0].Created as string
141+
)}, split:0, data/data.xml:22a1a29`,
139142
label: '123fsf4',
140143
value: mockedExperiments[0]
141144
},
142145
{
143146
description: '[exp-456]',
144-
detail: 'Created:Aug 19, 2022, split:0.2, data/data.xml:22a1a29',
147+
detail: `Created:${formatDate(
148+
mockedExperiments[1].Created as string
149+
)}, split:0.2, data/data.xml:22a1a29`,
145150
label: '456fsf4',
146151
value: mockedExperiments[1]
147152
},
148153
{
149154
description: '[exp-789]',
150-
detail: 'Created:Sep 15, 2022, split:0.3, data/data.xml:22a1a29',
155+
detail: `Created:${formatDate(
156+
mockedExperiments[2].Created as string
157+
)}, split:0.3, data/data.xml:22a1a29`,
151158
label: '789fsf4',
152159
value: mockedExperiments[2]
153160
}

extension/src/experiments/model/tree.test.ts

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import { RegisteredCommands } from '../../commands/external'
1616
import { getMarkdownString } from '../../vscode/markdownString'
1717
import { DecoratableTreeItemScheme, getDecoratableUri } from '../../tree'
1818
import { ExperimentStatus } from '../webview/contract'
19+
import { formatDate } from '../../util/date'
1920

2021
const mockedCommands = jest.mocked(commands)
2122
mockedCommands.registerCommand = jest.fn()
@@ -483,8 +484,9 @@ describe('ExperimentsTree', () => {
483484
iconPath: expect.anything(),
484485
id: 'exp-123',
485486
label: 'a123',
486-
tooltip:
487-
'|||\n|:--|--|\n| Created | Aug 19, 2022 |\n| data/data.xml | 22a1a29 |\n| ...ms.yaml:featurize.random_value | undefined |\n',
487+
tooltip: `|||\n|:--|--|\n| Created | ${formatDate(
488+
experiments[0].Created
489+
)} |\n| data/data.xml | 22a1a29 |\n| ...ms.yaml:featurize.random_value | undefined |\n`,
488490
type: ExperimentType.EXPERIMENT
489491
},
490492
{
@@ -499,8 +501,9 @@ describe('ExperimentsTree', () => {
499501
iconPath: expect.anything(),
500502
id: 'exp-456',
501503
label: 'b456',
502-
tooltip:
503-
'|||\n|:--|--|\n| Created | Sep 15, 2022 |\n| data/data.xml | 22a1a29 |\n| ...ms.yaml:featurize.random_value | [rbf,linear] |\n',
504+
tooltip: `|||\n|:--|--|\n| Created | ${formatDate(
505+
experiments[1].Created
506+
)} |\n| data/data.xml | 22a1a29 |\n| ...ms.yaml:featurize.random_value | [rbf,linear] |\n`,
504507
type: ExperimentType.EXPERIMENT
505508
},
506509
{
@@ -515,8 +518,9 @@ describe('ExperimentsTree', () => {
515518
iconPath: expect.anything(),
516519
id: 'exp-789',
517520
label: 'c789',
518-
tooltip:
519-
'|||\n|:--|--|\n| Created | Jul 3, 2022 |\n| data/data.xml | 22a1a29 |\n| ...ms.yaml:featurize.random_value | false |\n',
521+
tooltip: `|||\n|:--|--|\n| Created | ${formatDate(
522+
experiments[2].Created
523+
)} |\n| data/data.xml | 22a1a29 |\n| ...ms.yaml:featurize.random_value | false |\n`,
520524
type: ExperimentType.EXPERIMENT
521525
}
522526
])

0 commit comments

Comments
 (0)