Switch add Studio access token to update when Studio is connected (#3400)

Author: mattseddon

extension/package.json

@@ -117,6 +117,11 @@
         "command": "dvc.addStudioAccessToken",
         "category": "DVC"
       },
+      {
+        "title": "Update Studio Access Token",
+        "command": "dvc.updateStudioAccessToken",
+        "category": "DVC"
+      },
       {
         "title": "Add",
         "command": "dvc.addTarget",
@@ -635,7 +640,11 @@
         },
         {
           "command": "dvc.addStudioAccessToken",
-          "when": "dvc.commands.available && dvc.project.available"
+          "when": "dvc.commands.available && dvc.project.available && !dvc.studio.connected"
+        },
+        {
+          "command": "dvc.updateStudioAccessToken",
+          "when": "dvc.commands.available && dvc.project.available && dvc.studio.connected"
         },
         {
           "command": "dvc.addTarget",

extension/src/commands/external.ts

@@ -99,6 +99,7 @@ export enum RegisteredCommands {
   CONNECT_SHOW = 'dvc.showConnect',
   OPEN_STUDIO_SETTINGS = 'dvc.showStudioSettings',
   ADD_STUDIO_ACCESS_TOKEN = 'dvc.addStudioAccessToken',
+  UPDATE_STUDIO_ACCESS_TOKEN = 'dvc.updateStudioAccessToken',
   REMOVE_STUDIO_ACCESS_TOKEN = 'dvc.removeStudioAccessToken',
   EXPERIMENT_VIEW_SHARE_TO_STUDIO = 'dvc.views.experiments.shareExperimentToStudio'
 }

extension/src/connect/register.ts

@@ -21,6 +21,11 @@ export const registerConnectCommands = (
     () => connect.saveStudioAccessToken()
   )
 
+  internalCommands.registerExternalCommand(
+    RegisteredCommands.UPDATE_STUDIO_ACCESS_TOKEN,
+    () => connect.saveStudioAccessToken()
+  )
+
   internalCommands.registerExternalCommand(
     RegisteredCommands.REMOVE_STUDIO_ACCESS_TOKEN,
     () => connect.removeStudioAccessToken()

extension/src/telemetry/constants.ts

@@ -287,5 +287,6 @@ export interface IEventNamePropertyMapping {
   [EventName.CONNECT_SHOW]: undefined
   [EventName.OPEN_STUDIO_SETTINGS]: undefined
   [EventName.ADD_STUDIO_ACCESS_TOKEN]: undefined
+  [EventName.UPDATE_STUDIO_ACCESS_TOKEN]: undefined
   [EventName.REMOVE_STUDIO_ACCESS_TOKEN]: undefined
 }

webview/src/connect/components/App.test.tsx

@@ -96,5 +96,16 @@ describe('App', () => {
         type: MessageFromWebviewType.SET_STUDIO_SHARE_EXPERIMENTS_LIVE
       })
     })
+
+    it('should enable the user to update their studio token', () => {
+      const shareExperimentsLive = false
+      renderApp(true, shareExperimentsLive)
+      mockPostMessage.mockClear()
+      const button = screen.getByText('Update Token')
+      fireEvent.click(button)
+      expect(mockPostMessage).toHaveBeenCalledWith({
+        type: MessageFromWebviewType.SAVE_STUDIO_TOKEN
+      })
+    })
   })
 })

webview/src/connect/components/Studio.tsx

@@ -82,7 +82,7 @@ const Settings: React.FC<{
           appearance="primary"
           isNested={false}
           text={'Update Token'}
-          onClick={openStudio}
+          onClick={saveStudioToken}
         />
         <Button
           appearance="secondary"