Add deps to experiment table and columns tree (#1830)

* hack together deps data structure and get tests passing before refactoring

* refactor the entirety of columns collection - MAXIMUM EFFORT

* add colors into deps column headers

* fix path selection column names

* quick self review

* collect dep changes

* add dep test to build dynamic columns

* replace dep usage of build metric or param path

* rename name to label to be consistent

* refactor function args

* refactor column collection file

* refactor function params for collect metric or param

* refactor walk value tree

* reorder more args

* cut hash at 7 characters to match CLI

Author: mattseddon

extension/package.json

@@ -54,6 +54,14 @@
   },
   "contributes": {
     "colors": [
+      {
+        "id": "dvc.deps",
+        "description": "Color to indicate a DVC dep column in the experiments table",
+        "defaults": {
+          "dark": "#b079e7",
+          "light": "#4f1886"
+        }
+      },
       {
         "id": "dvc.metrics",
         "description": "Color to indicate a DVC metric column in the experiments table",

extension/src/cli/reader.ts

@@ -69,7 +69,7 @@ type RelPathObject<T> = {
 
 export type ValueTreeRoot = RelPathObject<ValueTreeOrError>
 
-interface ValueTreeNode {
+export interface ValueTreeNode {
   [key: string]: Value | ValueTree
 }
 
@@ -88,10 +88,12 @@ export interface BaseExperimentFields {
 type Dep = { hash: string; size: number; nfiles: null | number }
 type Out = Dep & { use_cache: boolean; is_data_source: boolean }
 
+export type Deps = RelPathObject<Dep>
+
 export interface ExperimentFields extends BaseExperimentFields {
   params?: ValueTreeRoot
   metrics?: ValueTreeRoot
-  deps?: RelPathObject<Dep>
+  deps?: Deps
   outs?: RelPathObject<Out>
 }
 

extension/src/experiments/columns/collect.ts

@@ -0,0 +1,58 @@
+import { sep } from 'path'
+import get from 'lodash.get'
+import {
+  ColumnAccumulator,
+  limitAncestorDepth,
+  mergeAncestors,
+  mergeValueColumn
+} from './util'
+import { buildDepPath } from '../paths'
+import { ColumnType } from '../../webview/contract'
+import { ExperimentFields } from '../../../cli/reader'
+import { getPathArray } from '../../../fileSystem/util'
+import { shortenForLabel } from '../../../util/string'
+
+export const collectDeps = (acc: ColumnAccumulator, data: ExperimentFields) => {
+  const { deps } = data
+  if (!deps) {
+    return
+  }
+  for (const [file, { hash }] of Object.entries(deps)) {
+    const pathArray = getPathArray(file)
+    const label = pathArray.pop() as string
+
+    const limitedDepthAncestors = limitAncestorDepth(pathArray, sep)
+    const path = buildDepPath(file)
+
+    mergeAncestors(
+      acc,
+      ColumnType.DEPS,
+      path,
+      limitedDepthAncestors,
+      (...pathArray: string[]) => buildDepPath(...pathArray)
+    )
+
+    mergeValueColumn(
+      acc,
+      path,
+      buildDepPath(...limitedDepthAncestors),
+      [ColumnType.DEPS, file],
+      label,
+      shortenForLabel(hash)
+    )
+  }
+}
+
+export const collectDepChanges = (
+  changes: string[],
+  workspaceData: ExperimentFields,
+  commitData: ExperimentFields
+) => {
+  for (const [file, { hash }] of Object.entries(
+    workspaceData?.[ColumnType.DEPS] || {}
+  )) {
+    if (get(commitData?.[ColumnType.DEPS], [file, 'hash']) !== hash) {
+      changes.push(buildDepPath(file))
+    }
+  }
+}