Skip to content

Commit 8fd01d7

Browse files
authored
Fix Created column presence in show only changed (#4435)
1 parent b7a6c51 commit 8fd01d7

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

extension/src/experiments/columns/collect/index.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -543,6 +543,7 @@ describe('collectColumnsWithChangedValues', () => {
543543
expect(changedColumns).toStrictEqual(
544544
columnsFixture.filter(({ path }) =>
545545
[
546+
'Created',
546547
'metrics:summary.json',
547548
'metrics:summary.json:loss',
548549
'metrics:summary.json:accuracy',

extension/src/experiments/columns/collect/index.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
collectMetricAndParamChanges,
77
collectMetricsAndParams
88
} from './metricsAndParams'
9-
import { Column, Commit, Experiment } from '../../webview/contract'
9+
import { Column, ColumnType, Commit, Experiment } from '../../webview/contract'
1010
import { getValue } from '../util'
1111
import {
1212
ExpRange,
@@ -167,7 +167,12 @@ const collectChangedPaths = (
167167
records: (Commit | Experiment)[]
168168
) => {
169169
const acc: string[] = []
170-
for (const { pathArray, path, hasChildren } of columns) {
170+
for (const { type, pathArray, path, hasChildren } of columns) {
171+
if (type === ColumnType.TIMESTAMP) {
172+
collectChangedPath(acc, path, [path], records)
173+
continue
174+
}
175+
171176
if (!pathArray || hasChildren) {
172177
continue
173178
}

0 commit comments

Comments
 (0)