Skip to content

Commit 9e2b576

Browse files
authored
Make Experiments Table Experiments Column Sticky (#1825)
* Add variable for row borders * Make experiments column sticky and rework borders to keep things looking okay
1 parent c93f3a8 commit 9e2b576

File tree

1 file changed

+28
-7
lines changed

1 file changed

+28
-7
lines changed

webview/src/experiments/components/table/styles.module.scss

Lines changed: 28 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
@import '../../../shared/variables.scss';
44

55
$nested-row-padding: 1.35rem;
6+
$row-border: 1px solid $border-color;
67

78
$edge-padding: 0.8rem;
89
$cell-padding: 0.5rem;
@@ -229,11 +230,21 @@ $workspace-row-edge-margin: $edge-padding - $cell-padding;
229230
}
230231

231232
.thead {
232-
border-bottom: 1px solid $border-color;
233+
border-bottom: $row-border;
233234
}
234235

235236
.tr {
236237
position: relative;
238+
& > *:first-child {
239+
background-color: $row-bg-color;
240+
position: sticky;
241+
left: 0;
242+
z-index: 3;
243+
}
244+
245+
&.oddRow > *:first-child {
246+
background-color: $row-bg-alt-color;
247+
}
237248
}
238249

239250
.headerRow {
@@ -291,10 +302,20 @@ $workspace-row-edge-margin: $edge-padding - $cell-padding;
291302
margin: 0.5rem 0;
292303
}
293304
.normalRowGroup {
294-
border: 1px solid $border-color;
305+
border-top: $row-border;
306+
border-bottom: $row-border;
295307
.oddRow {
296308
background-color: $row-bg-alt-color;
297309
}
310+
.td {
311+
&:first-child {
312+
border-left: $row-border;
313+
}
314+
315+
&:last-child {
316+
border-right: $row-border;
317+
}
318+
}
298319
}
299320
.workspaceRowGroup {
300321
border: none;
@@ -304,15 +325,15 @@ $workspace-row-edge-margin: $edge-padding - $cell-padding;
304325
padding-left: $workspace-row-edge-margin;
305326
.innerCell {
306327
padding-left: $cell-padding;
307-
border-left: 1px solid $border-color;
328+
border-left: $row-border;
308329
}
309330
}
310331

311332
&:last-child {
312333
padding-right: $workspace-row-edge-margin;
313334
.innerCell {
314335
padding-right: $cell-padding;
315-
border-right: 1px solid $border-color;
336+
border-right: $row-border;
316337
}
317338
}
318339
}
@@ -322,8 +343,8 @@ $workspace-row-edge-margin: $edge-padding - $cell-padding;
322343
height: 100%;
323344
width: 100%;
324345
background-color: none;
325-
border-top: 1px solid $border-color;
326-
border-bottom: 1px solid $border-color;
346+
border-top: $row-border;
347+
border-bottom: $row-border;
327348
}
328349
}
329350

@@ -529,6 +550,6 @@ $workspace-row-edge-margin: $edge-padding - $cell-padding;
529550
.thead {
530551
position: sticky;
531552
top: 0;
532-
z-index: 3;
553+
z-index: 4;
533554
background-color: $bg-color;
534555
}

0 commit comments

Comments
 (0)