Skip to content

Commit a71e761

Browse files
authored
Watch deps and outs files for experiment updates (#4784)
1 parent 7749280 commit a71e761

File tree

2 files changed

+17
-2
lines changed

2 files changed

+17
-2
lines changed

extension/src/experiments/data/collect.test.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,17 @@ describe('collectFiles', () => {
1010
files.sort()
1111

1212
expect(files).toStrictEqual([
13+
join('data', 'data.xml'),
14+
join('data', 'features'),
15+
join('data', 'prepared'),
1316
'metrics.json',
17+
'model.pkl',
1418
join('nested', 'params.yaml'),
1519
'params.yaml',
20+
join('src', 'evaluate.py'),
21+
join('src', 'featurization.py'),
22+
join('src', 'prepare.py'),
23+
join('src', 'train.py'),
1624
'summary.json'
1725
])
1826
})

extension/src/experiments/data/collect.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,14 @@
1-
import { ExpData, ExpShowOutput, MetricsOrParams } from '../../cli/dvc/contract'
1+
import {
2+
Deps,
3+
ExpData,
4+
ExpShowOutput,
5+
MetricsOrParams
6+
} from '../../cli/dvc/contract'
27
import { getExpData } from '../columns/collect'
38

49
const collectFilesFromKeys = (
510
acc: Set<string>,
6-
metricsOrParams: MetricsOrParams | null | undefined
11+
metricsOrParams: MetricsOrParams | Deps | null | undefined
712
): void => {
813
for (const file of Object.keys(metricsOrParams || {})) {
914
if (!file) {
@@ -22,6 +27,8 @@ const collectFilesFromExperiment = (
2227
}
2328
collectFilesFromKeys(acc, data.params)
2429
collectFilesFromKeys(acc, data.metrics)
30+
collectFilesFromKeys(acc, data.deps)
31+
collectFilesFromKeys(acc, data.outs)
2532
}
2633

2734
export const collectFiles = (

0 commit comments

Comments
 (0)