Exclude queued experiments from select experiments for plots quick pick (#2410)

Author: mattseddon

extension/src/experiments/model/index.ts

@@ -324,13 +324,21 @@ export class ExperimentsModel extends ModelWithPersistence {
   }
 
   public getExperimentsWithCheckpoints(): ExperimentWithCheckpoints[] {
-    return this.getExperiments().map(experiment => {
-      const checkpoints = this.getCheckpointsWithType(experiment.id)
+    const experimentsWithCheckpoints: ExperimentWithCheckpoints[] = []
+    for (const experiment of this.getExperiments()) {
+      const { id, queued } = experiment
+      if (queued) {
+        continue
+      }
+
+      const checkpoints = this.getCheckpointsWithType(id)
       if (!definedAndNonEmpty(checkpoints)) {
-        return experiment
+        experimentsWithCheckpoints.push(experiment)
+        continue
       }
-      return { ...experiment, checkpoints }
-    })
+      experimentsWithCheckpoints.push({ ...experiment, checkpoints })
+    }
+    return experimentsWithCheckpoints
   }
 
   public getExperimentParams(id: string) {

extension/src/test/suite/experiments/model/tree.test.ts

@@ -44,6 +44,7 @@ import {
   QuickPickItemWithValue,
   QuickPickOptionsWithTitle
 } from '../../../../vscode/quickPick'
+import * as QuickPickWrapper from '../../../../vscode/quickPick'
 import { Response } from '../../../../vscode/response'
 import { DvcExecutor } from '../../../../cli/dvc/executor'
 import { Param } from '../../../../experiments/model/modify/collect'
@@ -63,6 +64,7 @@ suite('Experiments Tree Test Suite', () => {
     disposable.dispose()
   })
 
+  // eslint-disable-next-line sonarjs/cognitive-complexity
   describe('ExperimentsTree', () => {
     const { colors } = checkpointPlotsFixture
     const { domain, range } = colors
@@ -150,6 +152,34 @@ suite('Experiments Tree Test Suite', () => {
       ).to.be.calledOnceWith(false)
     }).timeout(WEBVIEW_TEST_TIMEOUT)
 
+    it('should not show queued experiments in the dvc.views.experimentsTree.selectExperiments quick pick', async () => {
+      await buildPlots(disposable)
+
+      const mockQuickPickLimitedValues = stub(
+        QuickPickWrapper,
+        'quickPickLimitedValues'
+      ).resolves(undefined)
+
+      await commands.executeCommand(RegisteredCommands.EXPERIMENT_SELECT)
+
+      const [availableItems] = mockQuickPickLimitedValues.lastCall.args
+
+      expect(availableItems.length).to.be.greaterThan(0)
+      const queued = []
+
+      for (const experimentOrSeparator of availableItems) {
+        if (
+          (experimentOrSeparator?.value as { type: ExperimentType })?.type ===
+          ExperimentType.QUEUED
+        ) {
+          queued.push(experimentOrSeparator)
+        }
+      }
+
+      expect(mockQuickPickLimitedValues).to.be.calledOnce
+      expect(queued).to.deep.equal([])
+    }).timeout(WEBVIEW_TEST_TIMEOUT)
+
     it('should be able to select / de-select experiments using dvc.views.experimentsTree.selectExperiments', async () => {
       const { plots, messageSpy } = await buildPlots(disposable)