remove value_error param

Author: SBlokhuizen

waveform_editor/tendencies/base.py

@@ -79,11 +79,6 @@ class BaseTendency(param.Parameterized):
         default=None,
         doc="Error that occurred when processing user inputs.",
     )
-    value_error = param.ClassSelector(
-        class_=Exception,
-        default=None,
-        doc="Error that occurred when processing user inputs.",
-    )
 
     def __init__(self, **kwargs):
         self.annotations = Annotations()
@@ -258,7 +253,7 @@ def _setup_param(self, kwargs):
 
             self.annotations.add(
                 self.line_number,
-                f"{cleaned_error_msg}\nThis keyword argument is ignored.",
+                f"{cleaned_error_msg}\nThis keyword is ignored.",
                 is_warning=True,
             )
             # Ignore keyword argument with ValueError

waveform_editor/tendencies/linear.py

@@ -122,11 +122,12 @@ def _calc_values(self):
 
         try:
             values = solve_with_constraints(inputs, constraint_matrix)
-            self.value_error = None
         except InconsistentInputsError:
-            self.value_error = ValueError(
-                "Inputs are inconsistent: from + duration * rate != end"
+            error_msg = (
+                "Inputs are inconsistent: from + duration * rate != end\n"
+                "The 'from', 'to', and 'rate' values are set to 0.\n"
             )
+            self.annotations.add(self.line_number, error_msg, is_warning=True)
             values = (0.0, 0.0, 0.0)
 
         # Update state and cast to bool, as param does not like numpy booleans

waveform_editor/tendencies/periodic/periodic_base.py

@@ -64,17 +64,18 @@ def __init__(self, **kwargs):
     )
     def _calc_values(self):
         """Update all derived values in a single function"""
-        self.value_error = None  # clear value error
 
         # Determine frequency
         frequency = 1.0
         if self.user_frequency is not None:
             if self.user_period is not None and not np.isclose(
                 self.user_frequency, 1 / self.user_period
             ):
-                self.value_error = ValueError(
-                    "The frequency and period do not match! (freq != 1 / period)."
+                error_msg = (
+                    "The frequency and period do not match! (freq != 1 / period).\n"
+                    "The period will be ignored and only the frequency is used.\n"
                 )
+                self.annotations.add(self.line_number, error_msg, is_warning=True)
             frequency = self.user_frequency
         elif self.user_period is not None:
             frequency = 1 / self.user_period
@@ -106,9 +107,11 @@ def _calc_values(self):
             inputs[1] = 0.0
 
         if num_inputs > 2:
-            self.value_error = ValueError(
-                "Too many inputs: expected two out of {base, amplitude, min and max}."
+            error_msg = (
+                "Too many inputs: expected two out of {base, amplitude, min and max}.\n"
+                "The 'base', 'amplitude', 'min', and 'max' are set to 0.\n"
             )
+            self.annotations.add(self.line_number, error_msg, is_warning=True)
             values = (0.0, 0.0, 0.0, 0.0)
         else:
             values = solve_with_constraints(inputs, constraint_matrix)

waveform_editor/tendencies/repeat.py

@@ -18,10 +18,11 @@ def __init__(self, **kwargs):
 
         for item in waveform_dict:
             if item.get("type") == "piecewise":
-                self.value_error = ValueError(
+                error_msg = (
                     "Piecewise tendencies are currently not supported inside of a "
                     "repeated tendency."
                 )
+                self.annotations.add(self.line_number, error_msg)
 
         from waveform_editor.waveform import Waveform
 
@@ -30,9 +31,8 @@ def __init__(self, **kwargs):
             return
 
         if self.waveform.tendencies[0].start != 0:
-            self.value_error = ValueError(
-                "The starting point of the first repeated tendency is not set to 0."
-            )
+            error_msg = "The starting point of the first repeated must be set to 0."
+            self.annotations.add(self.line_number, error_msg)
 
         # Link the last tendency to the first tendency in the repeated waveform
         # We must lock the start to 0, otherwise it will take the start value of the