implement feedback Mireille

Author: SBlokhuizen

docs/source/cli.rst

@@ -77,7 +77,7 @@ This command reads the waveform definitions from the specified `YAML` file, eval
 **Arguments:**
 
 *   ``YAML``: Path to the input waveform YAML configuration file.
-*   ``URI``: The URI specifying the IMAS data entry to write to.
+*   ``URI``: The URI specifying the IMAS data entry or `IMAS NetCDF <https://imas-python.readthedocs.io/en/stable/netcdf.html>`_ filename to write to.
 
 **Options:**
 

docs/source/training/training.rst

@@ -119,15 +119,15 @@ Exercise 1c: Creating a sine wave - part 2
 
       In the previous execise, you might have noticed that there a multiple ways in which you can define the same 
       waveform. Recreate the waveform of previous exercise using only the following tendency parameters: 
-      ``type``, ``start``, ``duration``, ``period``, ``min``, and ``max``.
+      ``type``, ``duration``, ``period``, ``min``, and ``max``.
 
    .. md-tab-item:: Solution
 
       The resulting waveform should be:
 
       .. code-block:: yaml
 
-         - {type: sine, start: 10, duration: 5, period: 2, min: 0, max: 6}
+         - {type: sine, duration: 5, period: 2, min: 0, max: 6}
 
 
 Exercise 1d: Creating a sine wave - part 3
@@ -591,6 +591,12 @@ Exercise 5c: Exporting from the CLI
 
       This exports the same IDS as in previous exercise.
 
+      .. note:: You can also supply the path of a NetCDF file to export to an `IMAS NetCDF <https://imas-python.readthedocs.io/en/stable/netcdf.html>`_ file. For example:
+
+         .. code-block:: text
+
+            waveform-editor export-ids example.yaml output.nc --linspace 0,800,20
+
 .. _shape_editor_training:
 
 Plasma Shape Editor

waveform_editor/cli.py

@@ -107,7 +107,7 @@ def export_ids(yaml, uri, csv, linspace):
     \b
     Arguments:
       yaml: Path to the waveform YAML file.
-      uri: URI of the output Data Entry.
+      uri: URI of the output Data Entry or file path of output NetCDF file.
     \b
     Options:
       csv: CSV file containing a custom time array.

waveform_editor/gui/io/file_exporter.py

@@ -121,7 +121,7 @@ def __init__(self, manager):
     def _export_type_placeholder(self):
         """Output path placeholder, based on the selected export type."""
         return {
-            IDS_EXPORT: "e.g. imas:hdf5?path=testdb",
+            IDS_EXPORT: "e.g. imas:hdf5?path=testdb or test.nc",
             PNG_EXPORT: "e.g. /path/to/export/pngs",
             CSV_EXPORT: "e.g. /path/to/export/output.csv",
             PCSSP_EXPORT: "e.g. /path/to/export/output.xml",
@@ -131,7 +131,7 @@ def _export_type_placeholder(self):
     def _export_type_description(self):
         """Help description for the selected export type."""
         return {
-            IDS_EXPORT: "Please enter the output IMAS URI below:",
+            IDS_EXPORT: "Please enter the output IMAS URI or NetCDF file name below:",
             PNG_EXPORT: "Please enter an output folder below:",
             CSV_EXPORT: "Please enter an output file below:",
             PCSSP_EXPORT: "Please enter an output file below:",

waveform_editor/gui/selector/rename_modal.py

@@ -11,6 +11,7 @@ def __init__(self):
 
         self.label = pn.pane.Markdown("**Enter a new name for the waveform:**")
         self.input = pn.widgets.TextInput(placeholder="Enter new name")
+        self.input.param.watch(self._handle_accept, "enter_pressed")
         self.accept_button = pn.widgets.Button(
             name="Accept", button_type="primary", on_click=self._handle_accept
         )