Skip to content

Commit c35931a

Browse files
committed
fix periodic base tests
1 parent 84046c0 commit c35931a

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

waveform_editor/tendencies/base.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,11 @@ class BaseTendency(param.Parameterized):
6262
values from the start value of this tendency.
6363
""",
6464
)
65-
start_value = param.Number(doc="Value at self.start")
66-
end_value = param.Number(doc="Value at self.end")
65+
start_value = param.Number(default=0.0, doc="Value at self.start")
66+
end_value = param.Number(default=0.0, doc="Value at self.end")
6767

68-
start_derivative = param.Number(doc="Derivative at self.start")
69-
end_derivative = param.Number(doc="Derivative at self.end")
68+
start_derivative = param.Number(default=0.0, doc="Derivative at self.start")
69+
end_derivative = param.Number(default=0.0, doc="Derivative at self.end")
7070

7171
time_error = param.ClassSelector(
7272
class_=Exception,
@@ -128,12 +128,12 @@ def get_value(
128128
self, time: Optional[np.ndarray] = None
129129
) -> tuple[np.ndarray, np.ndarray]:
130130
"""Get the values on the provided time array."""
131-
pass
131+
return np.array([0]), np.array([0])
132132

133133
@abstractmethod
134134
def get_derivative(self, time: np.ndarray) -> np.ndarray:
135135
"""Get the derivative values on the provided time array."""
136-
pass
136+
return np.array([0])
137137

138138
@depends(
139139
"prev_tendency.times_changed",

waveform_editor/tendencies/periodic/periodic_base.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,8 @@ def _calc_values(self):
9797
if self.prev_tendency is None:
9898
inputs[0] = 0.0
9999
else:
100-
inputs[0] = self.prev_tendency.get_value(self.start)
100+
_, end_values = self.prev_tendency.get_value(np.array([self.start]))
101+
inputs[0] = end_values[0]
101102
num_inputs += 1
102103

103104
# Set defaults if problem is under-determined

0 commit comments

Comments
 (0)