change behaviour of base tendency if duration is negative, reenable batch call watchers when setting params

Author: SBlokhuizen

tests/tendencies/test_base.py

@@ -16,7 +16,7 @@
         (None, None, 30, 0, 30, 30, False),
         (None, None, None, 0, 1, 1, False),
         (10, 20, 40, 0, 1, 1, True),
-        (10, None, 5, 10, 1, 11, True),
+        (10, None, 5, 10, 1, 1, True),
         (10, -5, None, 10, 1, 11, True),
         (None, 0, None, 0, 1, 1, True),
     ],
@@ -55,7 +55,7 @@ def test_first_base_tendency(
         (None, None, 30, 10, 20, 30, False),
         (None, None, None, 10, 1, 11, False),
         (10, 20, 40, 10, 1, 11, True),
-        (10, None, 5, 10, 1, 11, True),
+        (10, None, 5, 10, 1, 1, True),
         (10, -5, None, 10, 1, 11, True),
         (None, 0, None, 10, 1, 11, True),
     ],

waveform_editor/tendencies/base.py

@@ -85,16 +85,16 @@ def __init__(self, **kwargs):
 
         unknown_kwargs = []
         super().__init__()
-
-        for param_name, value in kwargs.items():
-            if param_name not in self.param:
-                unknown_kwargs.append(param_name.replace("user_", ""))
-                continue
-
-            try:
-                setattr(self, param_name, value)
-            except Exception as error:
-                self._handle_error(error)
+        with param.parameterized.batch_call_watchers(self):
+            for param_name, value in kwargs.items():
+                if param_name not in self.param:
+                    unknown_kwargs.append(param_name.replace("user_", ""))
+                    continue
+
+                try:
+                    setattr(self, param_name, value)
+                except Exception as error:
+                    self._handle_error(error)
 
         self._handle_unknown_kwargs(unknown_kwargs)