Improve code coverage for DefaultITextProductEventProcessor

DEVSIX-5706

Author: yulian-gaponenko

itext.tests/itext.commons.tests/itext/commons/actions/processors/DefaultITextProductEventProcessorTest.cs

@@ -21,18 +21,71 @@ You should have received a copy of the GNU Affero General Public License
 along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
 using System;
+using iText.Commons.Actions.Confirmations;
+using iText.Commons.Actions.Data;
+using iText.Commons.Actions.Sequence;
+using iText.Commons.Ecosystem;
 using iText.Commons.Exceptions;
 using iText.Test;
+using iText.Test.Attributes;
 
 namespace iText.Commons.Actions.Processors {
     public class DefaultITextProductEventProcessorTest : ExtendedITextTest {
         [NUnit.Framework.Test]
         public virtual void ConstructorWithNullProductNameTest() {
-            NUnit.Framework.Assert.That(() =>  {
-                new DefaultITextProductEventProcessor(null);
+            Exception e = NUnit.Framework.Assert.Catch(typeof(ArgumentException), () => new DefaultITextProductEventProcessor
+                (null));
+            NUnit.Framework.Assert.AreEqual(CommonsExceptionMessageConstant.PRODUCT_NAME_CAN_NOT_BE_NULL, e.Message);
+        }
+
+        [NUnit.Framework.Test]
+        [LogMessage("{0} you are probably {1}", LogLevel = LogLevelConstants.INFO)]
+        public virtual void MessageIsLoggedTest() {
+            DefaultITextProductEventProcessorTest.TestDefaultITextProductEventProcessor testProcessor = new DefaultITextProductEventProcessorTest.TestDefaultITextProductEventProcessor
+                ();
+            ITextTestEvent e = new ITextTestEvent(new SequenceId(), CommonsProductData.GetInstance(), null, "test event"
+                );
+            NUnit.Framework.Assert.DoesNotThrow(() => testProcessor.OnEvent(new ConfirmEvent(e)));
+        }
+
+        [NUnit.Framework.Test]
+        [LogMessage("{0} you are probably {1}", LogLevel = LogLevelConstants.INFO, Count = 4)]
+        public virtual void MessageIsLoggedThreeTimesTest() {
+            int iterationsNumber = 15;
+            // "1" correspond to expected iterations with log messages:
+            // 1 0 0 0 0
+            // 0 1 0 0 0
+            // 1 0 0 0 1
+            DefaultITextProductEventProcessorTest.TestDefaultITextProductEventProcessor testProcessor = new DefaultITextProductEventProcessorTest.TestDefaultITextProductEventProcessor
+                ();
+            ITextTestEvent e = new ITextTestEvent(new SequenceId(), CommonsProductData.GetInstance(), null, "test event"
+                );
+            for (int i = 0; i < iterationsNumber; ++i) {
+                NUnit.Framework.Assert.DoesNotThrow(() => testProcessor.OnEvent(new ConfirmEvent(e)));
+            }
+        }
+
+        private class TestDefaultITextProductEventProcessor : DefaultITextProductEventProcessor {
+            public TestDefaultITextProductEventProcessor()
+                : base("test product") {
+            }
+
+            internal override long AcquireRepeatLevel(int lvl) {
+                switch (lvl) {
+                    case 0: {
+                        return 0;
+                    }
+
+                    case 1: {
+                        return 5;
+                    }
+
+                    case 2: {
+                        return 3;
+                    }
+                }
+                return 0;
             }
-            , NUnit.Framework.Throws.InstanceOf<ArgumentException>().With.Message.EqualTo(CommonsExceptionMessageConstant.PRODUCT_NAME_CAN_NOT_BE_NULL))
-;
         }
     }
 }

itext/itext.commons/itext/commons/actions/processors/DefaultITextProductEventProcessor.cs

@@ -30,10 +30,7 @@ You should have received a copy of the GNU Affero General Public License
 namespace iText.Commons.Actions.Processors {
     /// <summary>Defines a default strategy of product event processing.</summary>
     public class DefaultITextProductEventProcessor : AbstractITextProductEventProcessor {
-        private static readonly ILogger LOGGER = ITextLogManager.GetLogger(typeof(iText.Commons.Actions.Processors.DefaultITextProductEventProcessor
-            ));
-
-        private static readonly byte[] messageForLogging = Convert.FromBase64String("WW91IGFyZSB1c2luZyBpVGV4dCB1bmRlciB0aGUgQUdQTC4KCklmIHRoaXMgaXMgeW9"
+        internal static readonly byte[] MESSAGE_FOR_LOGGING = Convert.FromBase64String("WW91IGFyZSB1c2luZyBpVGV4dCB1bmRlciB0aGUgQUdQTC4KCklmIHRoaXMgaXMgeW9"
              + "1ciBpbnRlbnRpb24sIHlvdSBoYXZlIHB1Ymxpc2hlZCB5b3VyIG93biBzb3VyY2UgY2" + "9kZSBhcyBBR1BMIHNvZnR3YXJlIHRvby4KUGxlYXNlIGxldCB1cyBrbm93IHdoZXJlI"
              + "HRvIGZpbmQgeW91ciBzb3VyY2UgY29kZSBieSBzZW5kaW5nIGEgbWFpbCB0byBhZ3Bs" + "QGl0ZXh0cGRmLmNvbQpXZSdkIGJlIGhvbm9yZWQgdG8gYWRkIGl0IHRvIG91ciBsaXN"
              + "0IG9mIEFHUEwgcHJvamVjdHMgYnVpbHQgb24gdG9wIG9mIGlUZXh0IDcKYW5kIHdlJ2" + "xsIGV4cGxhaW4gaG93IHRvIHJlbW92ZSB0aGlzIG1lc3NhZ2UgZnJvbSB5b3VyIGVyc"
@@ -42,6 +39,9 @@ public class DefaultITextProductEventProcessor : AbstractITextProductEventProces
              + "XIsIHdlJ2xsIGV4cGxhaW4gaG93IHRvIGluc3RhbGwgeW91ciBsaWNlbnNlIGtleSB0" + "byBhdm9pZCB0aGlzIG1lc3NhZ2UuCklmIHlvdSdyZSBub3QgYSBjdXN0b21lciwgd2U"
              + "nbGwgZXhwbGFpbiB0aGUgYmVuZWZpdHMgb2YgYmVjb21pbmcgYSBjdXN0b21lci4=");
 
+        private static readonly ILogger LOGGER = ITextLogManager.GetLogger(typeof(iText.Commons.Actions.Processors.DefaultITextProductEventProcessor
+            ));
+
         private static readonly long[] REPEAT = new long[] { 10000L, 5000L, 1000L };
 
         private static readonly int MAX_LVL = REPEAT.Length - 1;
@@ -58,7 +58,7 @@ public class DefaultITextProductEventProcessor : AbstractITextProductEventProces
         /// <param name="productName">is a product name</param>
         public DefaultITextProductEventProcessor(String productName)
             : base(productName) {
-            repeatLevel = new AtomicLong(REPEAT[(int)level.Get()]);
+            repeatLevel = new AtomicLong(AcquireRepeatLevel((int)level.Get()));
         }
 
         public override void OnEvent(AbstractProductProcessITextEvent @event) {
@@ -72,12 +72,12 @@ public override void OnEvent(AbstractProductProcessITextEvent @event) {
                     if (level.IncrementAndGet() > MAX_LVL) {
                         level.Set(MAX_LVL);
                     }
-                    repeatLevel.Set(REPEAT[(int)level.Get()]);
+                    repeatLevel.Set(AcquireRepeatLevel((int)level.Get()));
                     isNeededToLogMessage = true;
                 }
             }
             if (isNeededToLogMessage) {
-                String message = iText.Commons.Utils.JavaUtil.GetStringForBytes(messageForLogging, iText.Commons.Utils.EncodingUtil.ISO_8859_1
+                String message = iText.Commons.Utils.JavaUtil.GetStringForBytes(MESSAGE_FOR_LOGGING, iText.Commons.Utils.EncodingUtil.ISO_8859_1
                     );
                 LOGGER.LogInformation(message);
                 System.Console.Out.WriteLine(message);
@@ -87,5 +87,9 @@ public override void OnEvent(AbstractProductProcessITextEvent @event) {
         public override String GetUsageType() {
             return "AGPL";
         }
+
+        internal virtual long AcquireRepeatLevel(int lvl) {
+            return REPEAT[lvl];
+        }
     }
 }