Consider not set LINE_HEIGHT property to be exactly the same as LineHeight.NORMAL

DEVSIX-3662

Autoported commit.
Original commit hash: [91eaf54cc]

Author: yulian-gaponenko

itext.tests/itext.layout.tests/itext/layout/renderer/LineRendererUnitTest.cs

@@ -40,7 +40,9 @@ source product.
 For more information, please contact iText Software Corp. at this
 address: [email protected]
 */
+using iText.IO.Font.Constants;
 using iText.IO.Util;
+using iText.Kernel.Font;
 using iText.Kernel.Geom;
 using iText.Kernel.Pdf.Xobject;
 using iText.Layout;
@@ -228,5 +230,25 @@ public virtual void LineRendererLayoutInHtmlModeWithLineHeightAndChildInHtmlMode
             NUnit.Framework.Assert.AreEqual(28.67920f, lineRenderer.maxAscent, EPS);
             NUnit.Framework.Assert.AreEqual(-21.32080f, lineRenderer.maxDescent, EPS);
         }
+
+        [NUnit.Framework.Test]
+        public virtual void LineRendererLayoutInHtmlModeWithLineHeightPropertyNotSet() {
+            LineRenderer lineRenderer = new LineRenderer();
+            lineRenderer.SetParent(CreateDocument().GetRenderer());
+            lineRenderer.SetProperty(Property.RENDERING_MODE, RenderingMode.HTML_MODE);
+            // Set fonts with different ascent/descent to line and text
+            lineRenderer.SetProperty(Property.FONT, PdfFontFactory.CreateFont(StandardFonts.HELVETICA));
+            TextRenderer textRenderer = new TextRenderer(new Text("text"));
+            textRenderer.SetProperty(Property.FONT, PdfFontFactory.CreateFont(StandardFonts.COURIER));
+            lineRenderer.AddChild(textRenderer);
+            LayoutResult layoutResLineHeightNotSet = lineRenderer.Layout(new LayoutContext(CreateLayoutArea(1000, 1000
+                )));
+            lineRenderer.SetProperty(Property.LINE_HEIGHT, LineHeight.CreateNormalValue());
+            LayoutResult layoutResLineHeightNormal = lineRenderer.Layout(new LayoutContext(CreateLayoutArea(1000, 1000
+                )));
+            Rectangle bboxLineHeightNotSet = layoutResLineHeightNotSet.GetOccupiedArea().GetBBox();
+            Rectangle bboxLineHeightNormal = layoutResLineHeightNormal.GetOccupiedArea().GetBBox();
+            NUnit.Framework.Assert.IsTrue(bboxLineHeightNotSet.EqualsWithEpsilon(bboxLineHeightNormal));
+        }
     }
 }

itext/itext.layout/itext/layout/renderer/LineRenderer.cs

@@ -101,8 +101,8 @@ public override LayoutResult Layout(LayoutContext layoutContext) {
                 GetHeight()).SetHeight(0).SetWidth(0));
             UpdateChildrenParent();
             float curWidth = 0;
-            if (RenderingMode.HTML_MODE.Equals(this.GetProperty<RenderingMode?>(Property.RENDERING_MODE)) && HasProperty
-                (Property.LINE_HEIGHT) && HasChildRendererInHtmlMode()) {
+            if (RenderingMode.HTML_MODE.Equals(this.GetProperty<RenderingMode?>(Property.RENDERING_MODE)) && HasChildRendererInHtmlMode
+                ()) {
                 float[] ascenderDescender = LineHeightHelper.GetActualAscenderDescender(this);
                 maxAscent = ascenderDescender[0];
                 maxDescent = ascenderDescender[1];

port-hash

@@ -1 +1 @@
-65011089bb7512af40c97fe2597e3d9d36e7dee8
+91eaf54cce38ee7a508fc4281bc268efefa19de1